Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade rainbow dependency #180

Merged
merged 1 commit into from
Jan 12, 2017
Merged

Downgrade rainbow dependency #180

merged 1 commit into from
Jan 12, 2017

Conversation

gnufied
Copy link
Contributor

@gnufied gnufied commented Jan 11, 2017

Rainbow in latest version seems to have become a
C extension which doesn't correctly compile in
certain environments. Lets downgrade it for now.

CC @iffyuva

Rainbow in latest version seems to have become a
C extension which doesn't correctly compile in
certain environments. Lets downgrade it for now.
@iffyuva
Copy link
Member

iffyuva commented Jan 11, 2017

@gnufied i will try this branch for couple of day, and let you know. thanks.

@gnufied
Copy link
Contributor Author

gnufied commented Jan 12, 2017

How did it go @iffyuva ?

@iffyuva
Copy link
Member

iffyuva commented Jan 12, 2017

@gnufied all good

@iffyuva iffyuva merged commit 8b86356 into master Jan 12, 2017
@iffyuva iffyuva deleted the downgrade-rainbow branch January 12, 2017 19:03
@ioquatix
Copy link

I think the latest release of rainbow may be fixing this, just FYI.

@swrobel
Copy link
Collaborator

swrobel commented Aug 1, 2017

There doesn't seem to be any C in the codebase ... I think there was just a bad 2.2.x release. See their changelog. A version bump would be appreciated to get rid of the gems/rainbow-2.1.0/lib/rainbow/color.rb:15: warning: constant ::Fixnum is deprecated on Ruby 2.4+

screen shot 2017-08-01 at 4 28 54 pm

@swrobel
Copy link
Collaborator

swrobel commented Aug 28, 2017

@iffyuva @gnufied ?

@gnufied
Copy link
Contributor Author

gnufied commented Aug 28, 2017

ack, will push a update tonight. sorry about it.

@gnufied
Copy link
Contributor Author

gnufied commented Aug 29, 2017

Their release of 2.2.2 appears to be borked still. I am sometimes forced to use ruby bundled with distributions and I am getting following error while trying to install that gem with default ruby installation on Ubuntu 16.04:

oot@xaos:/tmp# gem install invoker-1.5.5.gem 
Fetching: rainbow-2.2.2.gem (100%)
Building native extensions.  This could take a while...
ERROR:  Error installing invoker-1.5.5.gem:
        ERROR: Failed to build gem native extension.

    current directory: /var/lib/gems/2.3.0/gems/rainbow-2.2.2/ext
/usr/bin/ruby2.3 mkrf_conf.rb

current directory: /var/lib/gems/2.3.0/gems/rainbow-2.2.2/ext
/usr/bin/ruby2.3 -rubygems /usr/share/rubygems-integration/all/gems/rake-10.5.0/bin/rake RUBYARCHDIR=/var/lib/gems/2.3.0/extensions/x86_64-linux/2.3.0/rainbow-2.2.2 RUBYLIBDIR=/var/lib/gems/2.3.0/extensions/x86_64-linux/2.3.0/rainbow-2.2.2
/usr/bin/ruby2.3: No such file or directory -- /usr/share/rubygems-integration/all/gems/rake-10.5.0/bin/rake (LoadError)

rake failed, exit code 1

Gem files will remain installed in /var/lib/gems/2.3.0/gems/rainbow-2.2.2 for inspection.
Results logged to /var/lib/gems/2.3.0/extensions/x86_64-linux/2.3.0/rainbow-2.2.2/gem_make.out

It isn't looking great unfortunately..

@gnufied
Copy link
Contributor Author

gnufied commented Aug 29, 2017

Filed a issue with them - ku1ik/rainbow#69

Will push a fix as soon as they fix it.

@swrobel
Copy link
Collaborator

swrobel commented Aug 29, 2017

Have you tried updating Rubygems? It seems that people have other installation issues on Ruby 2.3+ that are resolved by updating rubygems, although that doesn't bode well. I've never seen a gem that requires a certain version of rubygems...

@gnufied
Copy link
Contributor Author

gnufied commented Aug 29, 2017

I installed rubygems via apt-get I don't think, I want to update installed rubygem via any other mechanism than apt upgrade (i.e when Ubuntu ships a newer version).

@swrobel
Copy link
Collaborator

swrobel commented Sep 18, 2017

Can you guys please do something about this. I can't upgrade to rubocop 0.50 because of this:

Bundler could not find compatible versions for gem "rainbow":
  In Gemfile:
    invoker x86_64-darwin-16 was resolved to 1.5.4, which depends on
      rainbow (~> 2.1.0)

    rubocop (~> 0.50.0) x86_64-darwin-16 was resolved to 0.50.0, which depends on
      rainbow (< 3.0, >= 2.2.2)

@gnufied
Copy link
Contributor Author

gnufied commented Sep 27, 2017

@swrobel I have removed rainbow as a dependency and moved this gem to colorize. Let me know if with version 1.5.5 things look good.

@swrobel
Copy link
Collaborator

swrobel commented Sep 28, 2017

@gnufied thank you! 1.5.5 fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants