Default process sleep_duration to 0 #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swrobel
force-pushed
the
allow-0-sleep-duration
branch
from
c7206ae to
0847d66
Compare
|
@gnufied do you still want to review these or should I just start merging? I'm interested in your review here, especially because you originally made the change to set sleep_duration to a minimum of 1 |
|
@gnufied I hate to bug you at all as I imagine you're quite busy, but I'd love to get your thoughts on this PR in particular. I'm happy to go ahead and merge all of them to save you the trouble of resolving conflicts. |
|
can you fix the conflict? I remember putting 1s sleep because spawning processes without sleep was causing some issues. |
|
Conflict fixed. I've been using this change for a while w/ 4 processes & have had no issues on macOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see no ill effects of this, so I don't see why everyone should be waiting 1 second between processes starting by default. It's wasting precious time. Fixes #226