-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Ubuntu 17+ w/ systemd-resolved (.localhost only) #233
Conversation
ece76de
to
5914239
Compare
|
||
def resolver_file | ||
using_systemd_resolved? ? nil : super | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand this correctly, we don't need socat when systemd-resolvd is being used? So why do we even install socat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to read list of packages from same install_packages
method here and for printing to user rather than duplicating the information in two places. But that duplication has always been there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gnufied as far as I'm aware, socat performs port proxying (eg: domain.localhost:80 -> 127.0.0.1:9000). I tried on Ubuntu 18 without it and it required accessing domain.localhost:9000 but I'm open to having someone more experienced test
My own usage of invoker these days does not involve using it as a DNS resolver, so I would like to test this bit more before merging. Sorry about delay. |
@gnufied any luck w/ your testing? |
@gnufied ping! |
@gnufied happy new year 🎉 Any chance you've had a chance to test? |
Fixes #219