Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cpu stacked widget #197

Open
wants to merge 9 commits into
base: cpu-profiling
Choose a base branch
from
Open

Cpu stacked widget #197

wants to merge 9 commits into from

Conversation

ishankhare07
Copy link
Contributor

reopening against cpu-profiling

sequence of widget initialization

  • AppMainWindow
    • mainWidget
    • mainLayout (QVBoxLayout)
    • StackedWidget (stackedWidget)
    • CentralWidget (centralMemoryWidget)
    • ActionToolBar (actionToolBar)
      • RibbonToolBar
    • cpuTab (QTabWidget)

usage of above widget is as follows

  • AppMainWindow
    • mainWidget
      • mainLayout
        • actionToolBar
          • ribbonToolBar
        • StackedWidget
          • page 1 -> centralMemoryWidget
          • page2 -> cpuTab
            • cpuTreeView

@ishankhare07 ishankhare07 added this to the v0.3.0 CPU profiling milestone Aug 6, 2015
@@ -35,8 +39,9 @@ class ActionToolbar : public QObject
Subscriber *subscriber;
ConnectionStates connectionState;
QThread subscriberThread;
AppMainwindow *window;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use sharedpointer here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are not instantiating AppMainwindow here
this variable will just hold a reference to mainwindow so that some of the function which need to call methods on mainwindow can call them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants