Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change due to mode rename #4190

Closed
blink1073 opened this issue Aug 22, 2016 · 5 comments
Closed

Breaking change due to mode rename #4190

blink1073 opened this issue Aug 22, 2016 · 5 comments

Comments

@blink1073
Copy link

The vue mode depends explicitly on jade.

https://github.com/codemirror/CodeMirror/blob/master/mode/vue/vue.js#L15

We found this when trying to WebPack all of the modes.

@jasongrout
Copy link
Contributor

jasongrout commented Aug 22, 2016

More context - 5.18.0 release today had the note "The mode formerly known as Jade was renamed to Pug."

@blink1073
Copy link
Author

Code (using asynchronous-style WebPack import):

require([`codemirror/mode/${mode}/${mode}`], () => {

Error:

ModuleNotFoundError: Module not found: Error: Cannot resolve 'file' or 'directory' ../jade/jade in /Users/ssilvester/workspace/jupyter/lab/jupyterlab/node_modules/codemirror/mode/vue

@blink1073
Copy link
Author

Confirmed that replacing all occurrences of jade with pug in vue.js fixes the issue.

@marijnh
Copy link
Member

marijnh commented Aug 23, 2016

Thanks for noticing that. Attached patch should help.

@blink1073
Copy link
Author

Thank you for the quick fix, and for CodeMirror in general!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants