Support tag text objects in xml / htmlmixed mode. #6356
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User can use
t
to operate on tag text objects. For example, given thefollowing html:
If the user's cursor (denoted by █) is inside "hello world!":
And they enter
dit
(delete inner tag), then the text inside theenclosing tag is deleted -- the following is the expected result:
If they enter
dat
(delete around tag), then the surrounding tags aredeleted as well:
This logic depends on the following:
Caveats
This is NOT a 100% accurate implementation of vim tag text objects.
For example, the following cases noop / are inconsistent with vim
behavior:
This addresses #3828.