feat(typescript): process TypeScript files #139

eventualbuddha · 2018-06-20T17:02:32Z

To support TypeScript, mostly we just needed to use the typescript parser plugin when the file being processed is TypeScript.

BREAKING CHANGE: This expands the set of file extensions that babel-codemod will look for to include .ts, .tsx, .es, .es6, and .mjs in addition to .js and .jsx.

Closes #137

lennyburdette · 2018-06-20T17:17:35Z

README.md

 ```

-This will re-write the files `path/to/file.js` and `another/file.js` by transforming them with the babel plugin `transform-module-name`. Multiple plugins may be specified, and multiple files or directories may be re-written at once.
+This will re-write the files `path/to/file.js` and `another/file.js` any supported files found in `a/directory` by transforming them with the babel plugin `transform-module-name`. Multiple plugins may be specified, and multiple files or directories may be re-written at once.


typo: "any supported files" -> "and any ..." or switch to oxford comma: "path/to/file.js, another/file.js, and supported files found in a/directory"

lennyburdette · 2018-06-20T17:21:25Z

src/AllSyntaxPlugin.ts

      for (let plugin of ALL_PLUGINS) {
-        if (plugin !== 'flow' || !opts.filename.endsWith('.ts')) {
+        let usePlugin =


bit nasty to read. what about:

const plugins = ALL_PLUGINS.filter(plugin => { if (plugin === 'flow' && isTypeScript) return false; if (plugin === 'typescript' && !isTypeScript) return false; return true; }); parserOpts.plugins.concat(...plugins);

or something similar?

I like that -- another way that might be cleaner is having BASE_PLUGINS and then something like

const plugins = isTypescript ? [...BASE_PLUGINS, 'typescript'] : [...BASE_PLUGINS, 'flow']

Good suggestions! I've gone with a hybrid.

cab

Awesome! Generally LGTM, mostly just nits.

cab · 2018-06-20T17:07:40Z

README.md

 ```

-This will re-write the files `path/to/file.js` and `another/file.js` by transforming them with the babel plugin `transform-module-name`. Multiple plugins may be specified, and multiple files or directories may be re-written at once.
+This will re-write the files `path/to/file.js` and `another/file.js` any supported files found in `a/directory` by transforming them with the babel plugin `transform-module-name`. Multiple plugins may be specified, and multiple files or directories may be re-written at once.


typo nit: "another/file.js any supported" should be "another/file.js and any supported"

Thanks, fixed.

cab · 2018-06-20T17:09:14Z

src/AllSyntaxPlugin.ts

 ];

 export default function(babel: typeof Babel) {
  return {
    manipulateOptions(opts: BabelOptions, parserOpts: ParseOptions) {
+      let isTypeScript = TypeScriptExtensions.has(extname(opts.filename));


Looks like this can be a const

cab · 2018-06-20T17:09:48Z

src/AllSyntaxPlugin.ts

      for (let plugin of ALL_PLUGINS) {
-        if (plugin !== 'flow' || !opts.filename.endsWith('.ts')) {
+        let usePlugin =


Same, could be const

cab · 2018-06-20T17:11:54Z

src/Options.ts

@@ -157,7 +157,7 @@ function getRequirableModulePath(modulePath: string): string {
    return resolve(modulePath);
  }

-  for (let ext of SUPPORTED_EXTENSIONS) {
+  for (let ext of RequireableExtensions) {


ext can be const

In general I've mostly followed Ember's conventions for let and const, but lately I've been tempted to just use const everywhere since it is sometimes needed for TypeScript to make certain guarantees when type checking. For now I'll leave these as let and maybe change them all in a later refactor.

cab · 2018-06-20T17:14:02Z

src/extensions.ts

@@ -0,0 +1,24 @@
+function union<T>(...sets: Array<Set<T>>) {


🙌 I like this refactor

Thanks 😄

cab · 2018-06-20T17:16:25Z

src/BabelPluginTypes.ts

@@ -6,7 +6,11 @@ export interface BabelOptions {
  filename: string;
 }
 export interface ParseOptions {
-  plugins: Array<string>;
+  sourceType?: 'module' | 'script';


It seems like 'script' isn't used as a value anywhere? Or is that user-configurable / future-proofing?

Ideally all these things would be provided by .d.ts files that come with e.g. @babel/parser, but we don't currently live in that world and I'm not sure how to pull them from DefinitelyTyped when the packages are namespaced, so I just manually write out a subset here. These are the two allowed values for sourceType, so I just encoded that here.

To support TypeScript, mostly we just needed to use the `typescript` parser plugin when the file being processed is TypeScript. BREAKING CHANGE: This expands the set of file extensions that babel-codemod will look for to include `.ts`, `.tsx`, `.es`, `.es6`, and `.mjs` in addition to `.js` and `.jsx`. Closes #137

babel-codemod-bot · 2018-06-20T18:06:03Z

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot 📦🚀

eventualbuddha mentioned this pull request Jun 20, 2018

support working with .ts files #137

Closed

lennyburdette reviewed Jun 20, 2018

View reviewed changes

cab reviewed Jun 20, 2018

View reviewed changes

eventualbuddha force-pushed the transform-typescript branch from 882cd0c to 07a4930 Compare June 20, 2018 17:44

eventualbuddha merged commit 00ae598 into master Jun 20, 2018

eventualbuddha deleted the transform-typescript branch June 20, 2018 17:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(typescript): process TypeScript files #139

feat(typescript): process TypeScript files #139

eventualbuddha commented Jun 20, 2018

lennyburdette Jun 20, 2018

eventualbuddha Jun 20, 2018

lennyburdette Jun 20, 2018

cab Jun 20, 2018 •

edited

Loading

eventualbuddha Jun 20, 2018

cab left a comment

cab Jun 20, 2018

eventualbuddha Jun 20, 2018

cab Jun 20, 2018

cab Jun 20, 2018

cab Jun 20, 2018

eventualbuddha Jun 20, 2018

cab Jun 20, 2018

eventualbuddha Jun 20, 2018

cab Jun 20, 2018

eventualbuddha Jun 20, 2018

babel-codemod-bot commented Jun 20, 2018

feat(typescript): process TypeScript files #139

feat(typescript): process TypeScript files #139

Conversation

eventualbuddha commented Jun 20, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cab Jun 20, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cab left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

babel-codemod-bot commented Jun 20, 2018

cab Jun 20, 2018 •

edited

Loading