ENTERPRISE-25: improve license message service #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytro-ndp
reviewed
Nov 28, 2016
| hide(): void { | ||
| let now: Date = new Date(); | ||
| this.$cookies.put(this.key, 'true', { | ||
| expires: new Date(now.getFullYear() + 1, now.getMonth(), now.getDate())// set the expiration to 12 months |
There was a problem hiding this comment.
Please, set period more or equals to 10 years.
|
@olexii4: please, add displaying error message if admin succeeded user license limit in time of adding new user at the Users page. |
|
@olexii4: it seems Dashboard doesn't remove flag USER_LICENSE_HAS_REACHED_ITS_LIMIT after adding valid license which set user limit to value which > actual user number. |
dmytro-ndp
suggested changes
Nov 28, 2016
olexii4
force-pushed
the
ENTERPRISE-25
branch
from
b2a26b8 to
67ac84a
Compare
|
done |
akurinnoy
approved these changes
Nov 29, 2016
olexii4
force-pushed
the
ENTERPRISE-25
branch
from
e636e84 to
6adbf07
Compare
ashumilova
approved these changes
Nov 30, 2016
Signed-off-by: Oleksii Orel <[email protected]>
olexii4
force-pushed
the
ENTERPRISE-25
branch
from
6adbf07 to
7d53a12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve license message service
Signed-off-by: Oleksii Orel [email protected]