-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt CLI for refactoring of CHE-4006 #1701
Conversation
Signed-off-by: Tyler Jewell <[email protected]>
Signed-off-by: Tyler Jewell <[email protected]>
Signed-off-by: Tyler Jewell <[email protected]>
Signed-off-by: Tyler Jewell <[email protected]>
# | ||
|
||
|
||
cmd_init_reinit_pre_action() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we had a typo there (reinit vs preinit) and it wasn't an issue as typo was in the hook name as well but now that the pre/post hooks are automated, is it an issue ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a typo - I checked it a couple times. It's a special hook that is only called if you are not reiniting the system.
I think that we could probably get rid of the cli entrypoint and use the entrypoint defined in the base image |
You are correct. I moved it into the base and it works now. I tested Che and Codenvy. Good idea. |
Signed-off-by: Tyler Jewell [email protected]
What does this PR do?
Applies refactoring changes to support Che CLI refactoring including updated image names, CLI API check, and different hook method names.
eclipse-che/che#4006
Changelog
Adapt CLI for CHE-4006 refactoring
Change
stop --force
to bestop --skip:graceful
Release Notes
N/A
Docs PR
N/A