Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt CLI for refactoring of CHE-4006 #1701

Merged
merged 8 commits into from
Feb 6, 2017
Merged

Adapt CLI for refactoring of CHE-4006 #1701

merged 8 commits into from
Feb 6, 2017

Conversation

TylerJewell
Copy link
Contributor

Signed-off-by: Tyler Jewell [email protected]

What does this PR do?

Applies refactoring changes to support Che CLI refactoring including updated image names, CLI API check, and different hook method names.

eclipse-che/che#4006

Changelog

Adapt CLI for CHE-4006 refactoring
Change stop --force to be stop --skip:graceful

Release Notes

N/A

Docs PR

N/A

Signed-off-by: Tyler Jewell <[email protected]>
Tyler Jewell added 2 commits February 4, 2017 09:18
Signed-off-by: Tyler Jewell <[email protected]>
Tyler Jewell added 4 commits February 5, 2017 09:35
Signed-off-by: Tyler Jewell <[email protected]>
Signed-off-by: Tyler Jewell <[email protected]>
#


cmd_init_reinit_pre_action() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we had a typo there (reinit vs preinit) and it wasn't an issue as typo was in the hook name as well but now that the pre/post hooks are automated, is it an issue ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a typo - I checked it a couple times. It's a special hook that is only called if you are not reiniting the system.

@benoitf
Copy link
Contributor

benoitf commented Feb 6, 2017

I think that we could probably get rid of the cli entrypoint and use the entrypoint defined in the base image
This will allow to be sure that it's the "base" stuff that loads the "cli" stuff and not cli stuff that call "base" stuff to then init the cli stuff. (in short : we can then be sure that base script can evolve and check what is defined in the cli image without any breakage)

@TylerJewell
Copy link
Contributor Author

You are correct. I moved it into the base and it works now. I tested Che and Codenvy. Good idea.

@TylerJewell TylerJewell added this to the 5.3.0 milestone Feb 6, 2017
@TylerJewell TylerJewell merged commit 3cf665b into master Feb 6, 2017
@TylerJewell TylerJewell deleted the cli-refactor branch February 6, 2017 15:39
@JamesDrummond JamesDrummond mentioned this pull request Feb 17, 2017
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants