CODENVY-1829 Add ability to use ws-agent from main assembly #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerJewell
reviewed
Feb 24, 2017
| @@ -73,6 +73,11 @@ generate_configuration_with_puppet() { | |||
| WRITE_PARAMETERS=" -e \"PATH_TO_CHE_ASSEMBLY=${CHE_ASSEMBLY}\"" | |||
| fi | |||
|
|
|||
| if [[ local_assembly && -f $(echo ${CHE_CONTAINER_ASSEMBLY_FULL_PATH}/lib/${WS_AGENT_ASSEMBLY}) ]]; then | |||
| info "Using ws-agent from main assembly" | |||
There was a problem hiding this comment.
info "config" "Using ws-agent from assembly"
benoitf
approved these changes
Feb 24, 2017
skabashnyuk
approved these changes
Feb 24, 2017
|
@codenvy/pm please approve |
riuvshin
approved these changes
Feb 24, 2017
bmicklea
requested review from
bmicklea
and removed request for
JamesDrummond
|
Will this need to be part of documentation for doing custom assemblies? |
|
don't think so, it is our internal mechanism for testing these custom assemblies |
bmicklea
approved these changes
Feb 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If Codenvy has been started with /assembly mount, it may contain ws-agent in assembly main (by default location lib/ws-agent.tar.gz). If CLI detects one, it will use this ws-agent.
What issues does this PR fix or reference?
#1829
Changelog
The CLI can now use the ws-agent from a mounted assembly.
Release Notes
n/a
Docs PR
n/a