[UD] fixes for "Get More RAM" widget and Billing info tab #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- restrict some inputs to enter only valid symbols; - set focus to input when widget is shown; - apply filter to round fractional part of calculated values in widget; Signed-off-by: Oleksii Kurinnyi <[email protected]>
benoitf
reviewed
Mar 1, 2017
| @@ -51,6 +52,7 @@ | |||
| che-label-name="State" | |||
| che-name="state" | |||
| che-place-holder="" | |||
| che-type-city | |||
There was a problem hiding this comment.
why do we have validator of cities for the state ?
There was a problem hiding this comment.
It's not validator of cities, it is just directive which prevent to enter not valid symbols to input.
There was a problem hiding this comment.
ok but my issue is that the name of validator contains "city" while it is more generic
There was a problem hiding this comment.
Could you suggest more suitable name?
There was a problem hiding this comment.
@akurinnoy well this change is not urgent I approved the PR. I don't have more suitable name. Maybe che-type-city and che-type-state directives that can be based on the same class.
There was a problem hiding this comment.
Thanks! I will update it soon.
ashumilova
approved these changes
Mar 1, 2017
olexii4
approved these changes
Mar 1, 2017
benoitf
approved these changes
Mar 1, 2017
slemeur
approved these changes
Mar 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds fixes for Billing info tab and "Get More RAM" widget:
What issues does this PR fix or reference?
N/A
Changelog
[UD] make inputs on "Get More RAM" widget and Billing info tab to allow to enter only valid symbols
Release Notes
N/A - bugfix
Docs PR
N/A - bugfix
Signed-off-by: Oleksii Kurinnyi [email protected]