Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use latest versions of providers #144

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ecs/network/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,15 @@ Creates networking resources needed for a standard ECS cluster setup:
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 0.12, <2.0 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 2.40.0 |
| <a name="requirement_null"></a> [null](#requirement\_null) | >= 2.1.2 |
| <a name="requirement_tls"></a> [tls](#requirement\_tls) | >= 2.0.1 |
| <a name="requirement_tls"></a> [tls](#requirement\_tls) | >= 3.2.0 |

## Providers

| Name | Version |
|------|---------|
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 2.40.0 |
| <a name="provider_null"></a> [null](#provider\_null) | >= 2.1.2 |
| <a name="provider_tls"></a> [tls](#provider\_tls) | >= 2.0.1 |
| <a name="provider_tls"></a> [tls](#provider\_tls) | >= 3.2.0 |

## Modules

Expand Down
1 change: 0 additions & 1 deletion ecs/network/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,6 @@ resource "tls_private_key" "lb_default" {
resource "tls_self_signed_cert" "lb_default" {
count = var.create ? 1 : 0

key_algorithm = "RSA"
private_key_pem = tls_private_key.lb_default[0].private_key_pem
validity_period_hours = 365 * 24

Expand Down
2 changes: 1 addition & 1 deletion ecs/network/versions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ terraform {

required_providers {
aws = ">= 2.40.0"
tls = ">= 2.0.1"
tls = ">= 3.2.0"
null = ">= 2.1.2"
}
}
6 changes: 3 additions & 3 deletions tools/bin/validate-module
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ validate() {
set -e

cd "$module_dir"
terraform init -backend=false
terraform validate
terraform init -backend=false >/dev/null
terraform validate -json | jq -r '.diagnostics[] | "\(.severity) \(.range.filename):\(.range.start.line) \(.summary). \(.detail)"'
}

validate_out=$(validate 2>&1)
validate_exit_code=$?

if [ $validate_exit_code -eq 0 ]; then
if [ $validate_exit_code -eq 0 ] && [ -z "$validate_out" ]; then
echo "✅ $module_dir"
else
echo "❌ $module_dir"
Expand Down
10 changes: 5 additions & 5 deletions versions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ terraform {

# Make sure all providers needed by any module are listed
required_providers {
aws = "3.41.0"
aws = "4.45.0"

archive = "2.1.0"
null = "3.1.0"
random = "3.1.0"
tls = "3.1.0"
archive = "2.2.0"
null = "3.2.1"
random = "3.4.3"
tls = "4.0.4"
}
}