Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable users to create their own prompts #10

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

wangkang
Copy link
Contributor

No description provided.

@ammario
Copy link
Member

ammario commented Oct 30, 2024

What exactly is the use case for custom prompt that isn't satisfied by a style guide? Ideally there's only one or the other. It's confusing at first glance why a user would choose either.

@wangkang
Copy link
Contributor Author

Thanks for your reply.

  1. Hardcoded prompts can’t meet more team needs unless they can be modified.
  2. As models evolve, prompts should also change.
  3. If having two modification methods may confuse users, I suggest keeping the ability to modify default prompts and removing the Style Guide.

There may be better methods. I'm looking forward to further discussions

@wangkang
Copy link
Contributor Author

wangkang commented Oct 31, 2024

Here is a use case:

When I use gpt-4o-mini, the prompt "3. Capitalize the subject line and don't end it with a period." causes all words in the subject line to be uppercase. However, when I use gpt-4o, the formatting appears correctly.

Then I modified this line:
3. Capitalize the subject line such as "Fix Issue 886" and don't end it with a period.

and it works fine with both gpt-4o-mini and gpt-4o.

Therefore, we can't assume that static hardcoded prompts will always work effectively. We should have the ability to modify them as needed.

@ammario
Copy link
Member

ammario commented Nov 2, 2024

Perhaps we move those 14 hard-coded rules into "default style guide"? I see your issue but think we can solve it still with one flag.

@wangkang
Copy link
Contributor Author

wangkang commented Nov 3, 2024

Good idea, I have changed the commit, it works for me

prompt.go Outdated Show resolved Hide resolved
prompt.go Outdated Show resolved Hide resolved
Copy link
Member

@ammario ammario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty for the contribution!

@ammario ammario merged commit fe29fc0 into coder:main Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants