Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(testing): add unit tests for common/util #2671

Merged
merged 4 commits into from
Feb 8, 2021
Merged

feat(testing): add unit tests for common/util #2671

merged 4 commits into from
Feb 8, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Feb 3, 2021 •
edited
Loading

This PR adds several unit tests for the src/common/util functions.

Screenshot

image

It increases our code coverage (Lines) from 46.88% to 49.53% (↑ 2.65%)
🟩 100% coverage for src/common/util
image

TODOS

  • write tests for logError
  • write tests for getOptions
  • write tests for generateUuid
  • update screenshot and percentage

@jsjoeio jsjoeio self-assigned this Feb 3, 2021
@jsjoeio jsjoeio marked this pull request as ready for review February 4, 2021 17:41
@jsjoeio jsjoeio requested a review from code-asher February 4, 2021 17:41
oxy
oxy suggested changes Feb 4, 2021
View reviewed changes
Copy link

@oxy oxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good! Might have to combine the two comments in test/package.json into a single line to avoid future issues, though.

test/package.json Show resolved Hide resolved
@jsjoeio jsjoeio requested a review from oxy February 4, 2021 22:19
@jsjoeio jsjoeio modified the milestones: v3.8.1, v3.8.2 Feb 5, 2021
oxy
oxy approved these changes Feb 8, 2021
View reviewed changes
Copy link

@oxy oxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsjoeio jsjoeio merged commit 7f629c3 into master Feb 8, 2021
@jsjoeio jsjoeio deleted the add-unit-tests branch February 8, 2021 18:32
@jsjoeio jsjoeio removed the request for review from code-asher February 8, 2021 23:27
@jsjoeio jsjoeio mentioned this pull request Feb 10, 2021
Closed
@jsjoeio jsjoeio added the testing Anything related to testing label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxy oxy oxy approved these changes

Assignees

@jsjoeio jsjoeio

Labels
testing Anything related to testing
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jsjoeio @oxy