Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guide.md): add caddy example for serving from sub-path #3217

Merged
merged 1 commit into from
Apr 26, 2021
Merged

docs(guide.md): add caddy example for serving from sub-path #3217

merged 1 commit into from
Apr 26, 2021

Conversation

catthehacker
Copy link
Contributor

Simple example of serving from sub-path in Caddy

@catthehacker catthehacker requested a review from a team as a code owner April 26, 2021 08:01
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #3217 (95164d0) into main (d31439e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3217   +/-   ##
=======================================
  Coverage   46.81%   46.81%           
=======================================
  Files          23       23           
  Lines        1194     1194           
  Branches      237      237           
=======================================
  Hits          559      559           
  Misses        451      451           
  Partials      184      184           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d31439e...95164d0. Read the comment docs.

@jsjoeio jsjoeio added the docs Documentation related label Apr 26, 2021
@jsjoeio jsjoeio changed the title feat: add caddy example for serving from sub-path docs(guide.md): add caddy example for serving from sub-path Apr 26, 2021
@jsjoeio jsjoeio added this to the v3.9.4 milestone Apr 26, 2021
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fantastic addition to our docs! 👏

Thanks so much @catthehacker 🎉

@jsjoeio jsjoeio added merge when passing new contributor For PRs by first-time contributor labels Apr 26, 2021
@repo-ranger
Copy link
Contributor

repo-ranger bot commented Apr 26, 2021

Thanks for making your first contribution! 🙂

@repo-ranger repo-ranger bot merged commit a872850 into coder:main Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related new contributor For PRs by first-time contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants