Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp debugging section #3224

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Revamp debugging section #3224

merged 1 commit into from
Apr 26, 2021

Conversation

code-asher
Copy link
Member

  • Most people leave the logs out so add a section for them in the issue
    template.
  • Remove the VS Code logs because those get sent to stdout now and will
    show up in our logs.
  • Separate browser console and network.

- Most people leave the logs out so add a section for them in the issue
  template.
- Remove the VS Code logs because those get sent to stdout now and will
  show up in our logs.
- Separate browser console and network.
@code-asher code-asher requested a review from a team as a code owner April 26, 2021 16:11
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #3224 (95f65d9) into main (4fd39b2) will not change coverage.
The diff coverage is n/a.

❗ Current head 95f65d9 differs from pull request most recent head a5674d9. Consider uploading reports for the commit a5674d9 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3224   +/-   ##
=======================================
  Coverage   46.81%   46.81%           
=======================================
  Files          23       23           
  Lines        1194     1194           
  Branches      237      237           
=======================================
  Hits          559      559           
  Misses        451      451           
  Partials      184      184           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fd39b2...a5674d9. Read the comment docs.

Copy link

@oxy oxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'm confused about the minor inconsistency with ~/.local/share/code-server/logs

@@ -330,8 +330,8 @@ Once this is done, replicate the issue you're having then collect logging
information from the following places:

1. The most recent files from `~/.local/share/code-server/coder-logs`.
2. The most recently created directory in the `~/.local/share/code-server/logs` directory.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line removed here, but still present in the issue template;

Once this is done, replicate the issue you're having then collect logging
information from the following places:

1. The most recent files from ~/.local/share/code-server/coder-logs.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line added here, but removed from the debugging FAQ;

@code-asher
Copy link
Member Author

Ah yeah it looks a bit confusing because we have the unfortunate names of logs and coder-logs.

~/.local/share/code-server/logs < was removed
~/.local/share/code-server/coder-logs < was kept

@oxy
Copy link

oxy commented Apr 26, 2021

Oh lordy - I can't believe I missed the coder- in there! My bad.

Copy link

@oxy oxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@code-asher code-asher merged commit f746212 into coder:main Apr 26, 2021
@code-asher code-asher deleted the issue-logs branch April 26, 2021 17:56
@jsjoeio jsjoeio added this to the v3.9.4 milestone Apr 26, 2021
@jsjoeio jsjoeio added the chore Related to maintenance or clean up label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants