Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): remove eslint-plugin-jest-playwright #3260

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Apr 29, 2021

This PR addresses forgotten work from when we migrated from jest-playwright to playwright-test.

@jsjoeio jsjoeio requested a review from a team as a code owner April 29, 2021 17:47
@jsjoeio jsjoeio self-assigned this Apr 29, 2021
@jsjoeio jsjoeio added the dependencies Pull requests that update a dependency file label Apr 29, 2021
@jsjoeio jsjoeio added this to the v3.9.4 milestone Apr 29, 2021
Copy link

@oxy oxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #3260 (070b439) into main (6dace0f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3260   +/-   ##
=======================================
  Coverage   46.90%   46.90%           
=======================================
  Files          23       23           
  Lines        1196     1196           
  Branches      237      237           
=======================================
  Hits          561      561           
  Misses        451      451           
  Partials      184      184           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dace0f...070b439. Read the comment docs.

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Apr 29, 2021

Hmm... These tests are passing on this branch locally. I am going to merge manually and open a separate PR to fix the tests.

image

@jsjoeio jsjoeio merged commit 0d9fe6f into main Apr 29, 2021
@jsjoeio jsjoeio deleted the jsjoeio/fix-playwright-dep branch April 29, 2021 22:45
@jsjoeio jsjoeio added the chore Related to maintenance or clean up label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants