Add flag for toggling permessage-deflate #3286
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3286 +/- ##
==========================================
+ Coverage 54.78% 57.54% +2.76%
==========================================
Files 23 24 +1
Lines 1265 1279 +14
Branches 286 290 +4
==========================================
+ Hits 693 736 +43
+ Misses 460 441 -19
+ Partials 112 102 -10
Continue to review full report at Codecov.
|
👏 You + Codecov helping us build a habit of increasing code coverage! |
code-asher
force-pushed
the
permessage-deflate
branch
from
2889725 to
6ff495e
Compare
code-asher
force-pushed
the
permessage-deflate
branch
3 times, most recently
from
1da4d67 to
fd4b784
Compare
This is so they can be unit tested.
All it does is log and exit which is what the caller will be doing on an error anyway (see entry).
code-asher
force-pushed
the
permessage-deflate
branch
from
e06725d to
a882be5
Compare
|
Refactored; it's not any more pure but it's simpler. I think we could have an interesting discussion on whether we should pass Coverage went down because of the code added in entry so I split some of those functions out in order to test them. One of them is now used for all the integration tests so those should reflect reality more closely now. |
| @@ -12,15 +12,15 @@ describe("health", () => { | |||
| }) | |||
|
|
|||
| it("/healthz", async () => { | |||
| ;[, , codeServer] = await integration.setup(["--auth=none"], "") | |||
| codeServer = await integration.setup(["--auth=none"], "") | |||
There was a problem hiding this comment.
this looks way cleaner/easier to read 👏
There was a problem hiding this comment.
👍 yea, the code before was 🤨 kinda inscrutable, but then again, I'm not a JavaScript/TypeScript person
Agreed! I prefer passing args because it's easier to mock/test things. But global access does come in handy when writing code. It would be a good discussion though. |
|
I'm going to fix the trivy scan in a PR soon so you can ignore for now |
This is a workaround for #3014 until we figure it out (if it is indeed related which it might not be; the zlib errors could merely be side effects of a connection issue).