Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(helm): add required env for docker-in-docker #5045

Merged
merged 2 commits into from
Mar 30, 2022

Conversation

cjtim
Copy link
Contributor

@cjtim cjtim commented Mar 30, 2022

Fixes #199
Hi, I see there's an example of docker in docker in extraContainers
but in order to use it, you need to set DOCKER_HOST in code-server too

I think it a good idea to add more since we already had dind in extraContainers

Working in my RKE cluster v1.21.10

@jsjoeio jsjoeio self-assigned this Mar 30, 2022
@jsjoeio jsjoeio added the docs Documentation related label Mar 30, 2022
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #5045 (851e976) into main (5341294) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5045   +/-   ##
=======================================
  Coverage   71.30%   71.30%           
=======================================
  Files          30       30           
  Lines        1683     1683           
  Branches      373      373           
=======================================
  Hits         1200     1200           
  Misses        413      413           
  Partials       70       70           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5341294...851e976. Read the comment docs.

@jsjoeio jsjoeio added this to the April 2022 milestone Mar 30, 2022
@jsjoeio jsjoeio merged commit 9c4f41d into coder:main Mar 30, 2022
@jsjoeio jsjoeio modified the milestones: April 2022, 4.3.0 Apr 13, 2022
TinLe pushed a commit to TinLe/code-server that referenced this pull request Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker In Docker for code-server
2 participants