Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using deprecated codersdk.LogsSender function #260

Closed
Tracked by #132
johnstcn opened this issue Jul 2, 2024 · 0 comments · Fixed by #264
Closed
Tracked by #132

Stop using deprecated codersdk.LogsSender function #260

johnstcn opened this issue Jul 2, 2024 · 0 comments · Fixed by #264
Assignees
@johnstcn

Comments

@johnstcn
Copy link
Member

johnstcn commented Jul 2, 2024

We currently use a manually-vendored version of codersdk.LogsSender. This is deprecated and will be removed eventually.
Instead, we should use NewLogSender which uses the versioned agent API.
@johnstcn johnstcn mentioned this issue Jul 2, 2024
Closed
36 tasks
@johnstcn johnstcn self-assigned this Jul 4, 2024
@johnstcn johnstcn mentioned this issue Jul 4, 2024
Merged
johnstcn added a commit that referenced this issue Jul 5, 2024
@johnstcn
feat: send logs using agent api v2 if available (#264)
2538741 
Closes #260

- Removes manually vendored codersdk, we're back on the real deal now
- Moves logging setup to package internal/eblog
- Modifies logging to use new agent api v2 methods, falling back to PatchLogs
- Adds ENVBUILDER_VERBOSE

Tested manually against Coder version 2.8.0, 2.9.0, and 2.13.0.

(cherry picked from commit 5be0611)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: send logs using agent api v2 if available coder/envbuilder
1 participant
@johnstcn