Retry access token refresh errors #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krames
commented
Dec 7, 2017
| @@ -62,7 +62,7 @@ def get(user_name_or_project_key, repo_name, hook_uuid) | |||
| _validate_user_repo_params(user, repo) unless user? && repo? | |||
|
|
|||
| get_request( | |||
| "/2.0/repositories/#{user_name}/#{repo_name}/hooks/#{hook_uuid}" | |||
| "/2.0/repositories/#{user_name_or_project_key}/#{repo_name}/hooks/#{hook_uuid}" | |||
markphelps
reviewed
Dec 7, 2017
lib/bitbucket_rest_api/request.rb
Outdated
| yield | ||
| rescue BitBucket::Error::RefreshToken | ||
| count += 1 | ||
| if count < 3 |
There was a problem hiding this comment.
I think you want <= 3 here if you want it retry 3 times after the first failed attempt.
markphelps
approved these changes
Dec 8, 2017
| @@ -11,6 +13,9 @@ def on_complete(env) | |||
| when 400 | |||
| raise BitBucket::Error::BadRequest.new(env) | |||
| when 401 | |||
| if env[:body] =~ REFRESH_TOKEN | |||
There was a problem hiding this comment.
I guess there's no way to determine if its a 'retriable' 401 without using regex to parse the message?
There was a problem hiding this comment.
Not that I can think of and unfortunately, I have not been able to reproduce this locally so I am sort of flying blind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are still seeing HTTP 401 exceptions containing the body
Access token expired. Use your refresh token to obtain a new access token.This PR detects these requests and then attempts to retry them 3 times using an incrmental back of of (count * 0.1 seconds). After the 3rd attempt is reached we just throw a
BitBucket::Error::RefreshTokenexception.