Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendors/locks deps #2

Merged
merged 1 commit into from
Oct 11, 2017
Merged

Vendors/locks deps #2

merged 1 commit into from
Oct 11, 2017

Conversation

LarsFronius
Copy link

An upstream change to the go-sql-driver API go-sql-driver/mysql#676 has caused this project to fail building.

(image: codeship_app) (service: app) # github.com/codeship/migrate/driver/mysql
src/github.com/codeship/migrate/driver/mysql/mysql.go:57:23: undefined: mysql.MySQLWarnings

This change should make sure those breaking upstream changes don't tickle down into the migrate project in an uncontrolled way anymore.

markphelps
markphelps approved these changes Oct 11, 2017
View reviewed changes
Copy link

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. did you run dep prune as well?

@LarsFronius
Copy link
Author

I was dogfooding my very own hand made make deps command 🐩 , that calls it, yup!

@LarsFronius LarsFronius merged commit 9cf6562 into codeship:master Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markphelps markphelps markphelps approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LarsFronius @markphelps