-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dictionary with more misspellings and disabled names #1425
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments from me.
Thanks for review -- I still think it might be a good idea to consider including the names -- and also note, the dictionary already contains But if you feel that it's better to remove all mention of names and include misspellings that are also people's names, I could remove the names from this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments
I'm merely another user, but the pragmatic solution may be to split the uncontentious non-name changes into another PR so they can be merged, while a consensus is potentially reached over what's in a name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now removed names from this PR
Updated The idea in #103 is interesting; it seems like in general we could trend towards one more complicated dictionary, or multiple dictionaries/ignore-lists with more functionality As-is, for my particular use case, I'm going to have to keep my own ignore list, although ignoring common proper nouns seems like a reasonable think to potentially include in codespell itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @qyearsley . Please open a new one with the other more "controversial" changes. And we'll see where #1437 goes too. |
@qyearsley we now have a solution. If you can add the names in a new PR to https://github.com/codespell-project/codespell/blob/master/codespell_lib/data/dictionary_names.txt would be great! |
Great news, good to know, thanks :-) |
This PR: