Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fomrat->format and friends #1513

Merged
merged 2 commits into from
May 21, 2020
Merged

Add fomrat->format and friends #1513

merged 2 commits into from
May 21, 2020

Conversation

peternewman
Copy link
Collaborator

No description provided.

@larsoner
Copy link
Member

@peternewman I'm finding the requirement to update each branch and also require an approved review to be a bit burdensome. It adds some minutes to each review+merge cycle, when before the approval could be implicit just by merging. And we haven't had many cases where not being up to date when merging was a problem -- conflicts will be caught anyway, which should flag ordering problems, and collisions with corrections from one PR being errors in another should be low. Okay to remove these restrictions?

@larsoner larsoner merged commit 4d0d484 into master May 21, 2020
@larsoner larsoner deleted the peternewman-fomrat branch May 21, 2020 17:58
@peternewman
Copy link
Collaborator Author

@peternewman I'm finding the requirement to update each branch and also require an approved review to be a bit burdensome. It adds some minutes to each review+merge cycle, when before the approval could be implicit just by merging.

The only thing is this wouldn't stop us just merging our own PRs, either accidentally or on purpose.

And we haven't had many cases where not being up to date when merging was a problem -- conflicts will be caught anyway, which should flag ordering problems, and collisions with corrections from one PR being errors in another should be low.

It does mean new CI improvements will only get run when a PR is merged (therefore giving us the burden to fix them).

Okay to remove these restrictions?

I've removed them for now. See if that seems any better.

@peternewman
Copy link
Collaborator Author

I've added "Include administrators" back on @larsoner as with the last set of changes there was nothing to stop me accidentally editing master directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants