Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue migrating #135 (letter 'n') #289

Merged
merged 1 commit into from
Jan 9, 2018

Conversation

luzpaz
Copy link
Collaborator

@luzpaz luzpaz commented Jan 9, 2018

It seems I forgot to open a PR for this one.

@codecov-io
Copy link

Codecov Report

Merging #289 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #289   +/-   ##
=======================================
  Coverage   87.81%   87.81%           
=======================================
  Files           2        2           
  Lines         665      665           
  Branches       93       93           
=======================================
  Hits          584      584           
  Misses         62       62           
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee7accf...5239b57. Read the comment docs.

noveau->nouveau
Novermber->November
nowdays->nowadays
nowe->now
no compliant->noncompliant
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be used legitimately

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. These are good examples of #255
I wonder if there is a way we can consider entering them in to codespell somehow and use some regex look aheads to utilize them?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in this PR

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough

@luzpaz
Copy link
Collaborator Author

luzpaz commented Jan 9, 2018

removed the offending entry. Ready to be merged.

@larsoner larsoner merged commit 50f8af9 into codespell-project:master Jan 9, 2018
@luzpaz luzpaz deleted the letter-n branch January 9, 2018 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants