-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continue migrating #135 (letter 'n') #289
Conversation
Codecov Report
@@ Coverage Diff @@
## master #289 +/- ##
=======================================
Coverage 87.81% 87.81%
=======================================
Files 2 2
Lines 665 665
Branches 93 93
=======================================
Hits 584 584
Misses 62 62
Partials 19 19 Continue to review full report at Codecov.
|
codespell_lib/data/dictionary.txt
Outdated
noveau->nouveau | ||
Novermber->November | ||
nowdays->nowadays | ||
nowe->now | ||
no compliant->noncompliant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be used legitimately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. These are good examples of #255
I wonder if there is a way we can consider entering them in to codespell somehow and use some regex look aheads to utilize them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair enough
removed the offending entry. Ready to be merged. |
It seems I forgot to open a PR for this one.