Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fempto, mimimun and valiator #351

Merged
merged 2 commits into from
Feb 16, 2018

Conversation

peternewman
Copy link
Collaborator

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 16, 2018

Codecov Report

Merging #351 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #351   +/-   ##
=======================================
  Coverage   87.81%   87.81%           
=======================================
  Files           2        2           
  Lines         665      665           
  Branches       93       93           
=======================================
  Hits          584      584           
  Misses         62       62           
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f4966b...a18bf54. Read the comment docs.

Copy link
Collaborator

@luzpaz luzpaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 only thing is that you should squash the commits down in to 1 commit.

@larsoner
Copy link
Member

only thing is that you should squash the commits down in to 1 commit.

This can be done while merging. Thanks for the fixes

@larsoner larsoner merged commit 91929db into codespell-project:master Feb 16, 2018
@peternewman
Copy link
Collaborator Author

Thanks. Yeah squashing is a pain/impossible if using the GitHub web UI, which is where I did these particular edits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants