Typos from the OCaml language #795

Fourchaux · 2019-01-08T00:03:10Z

Some typos from:

https://github.com/ocaml/ocaml/pull/1280/files

luzpaz · 2019-01-12T00:06:20Z

codespell_lib/data/dictionary.txt

@@ -9890,6 +9916,7 @@ perpertrated->perpetrated
 perphas->perhaps
 perpindicular->perpendicular
 perserverance->perseverance
+persevered->preserved


persevered is the past tense of persevere so not sure we should add this one

OK. Line deleted.

luzpaz · 2019-01-12T17:23:17Z

Not sure why it's failing the CI

larsoner · 2019-01-12T18:34:42Z

You should check the log

https://travis-ci.org/codespell-project/codespell/jobs/478779250#L735

peternewman

A few comments from me.

peternewman · 2019-01-16T11:34:07Z

codespell_lib/data/dictionary.txt

@@ -1844,6 +1847,7 @@ brach->branch
 brackeds->brackets
 brackground->background
 bradcast->broadcast
+brakpoint->breakpoint


You could also add the plural of this (breakpoints).

peternewman · 2019-01-16T11:34:50Z

codespell_lib/data/dictionary.txt

@@ -3720,6 +3726,7 @@ debians->Debian's
 debth->depth
 debths->depths
 debufs->debugfs
+debugee->debuggee


I'm not sure this is a real word, I assume you mean the person who did the debugging?

e.g. check https://en.wiktionary.org/wiki/debuggee

peternewman · 2019-01-16T11:36:35Z

codespell_lib/data/dictionary.txt

@@ -5096,6 +5106,8 @@ encosing->enclosing
 encosure->enclosure
 encounterd->encountered
 encouraing->encouraging
+encouter->encounter


Can you add the plural.

peternewman · 2019-01-16T11:37:46Z

codespell_lib/data/dictionary.txt

@@ -6004,6 +6020,7 @@ foriegn->foreign
 forld->fold
 forlder->folder
 forlders->folders
+forma->format, from,


Please remove this due to https://en.wikipedia.org/wiki/Pro_forma .

ok, removed.

peternewman · 2019-01-16T11:39:08Z

codespell_lib/data/dictionary.txt

@@ -9469,6 +9493,7 @@ othwerwise->otherwise
 othwhise->otherwise
 otiginal->original
 otion->option
+otional->optional


Add notional as a suggestion

peternewman · 2019-01-16T11:39:43Z

codespell_lib/data/dictionary.txt

@@ -9719,6 +9744,7 @@ parrent->parent
 parseing->parsing
 parsering->parsing
 parsin->parsing
+parstree->parsetree


Shouldn't that be "parse tree"?

ok, corrected.

peternewman · 2019-01-16T11:40:32Z

codespell_lib/data/dictionary.txt

@@ -12897,6 +12925,7 @@ sucessor->successor
 sucessot->successor
 sucide->suicide
 sucidial->suicidal
+sudmobules->submodules


Add the singular.

peternewman · 2019-01-16T11:40:48Z

codespell_lib/data/dictionary.txt

@@ -13401,6 +13430,7 @@ theres->there's
 therfore->therefore
 theri->their, there,
 thes->this, these,
+theses->these


Add thesis as a suggestion.

peternewman · 2019-01-16T11:41:11Z

codespell_lib/data/dictionary.txt

@@ -13808,6 +13838,7 @@ tyhe->they
 tyies->tries
 tyope->type
 typcial->typical
+typecheking->typechecking


Add typechek->typecheck

peternewman

LGTM

larsoner · 2019-01-16T17:05:26Z

codespell_lib/data/dictionary.txt

@@ -4086,6 +4096,7 @@ desccription->description
 descencing->descending
 descendands->descendants
 descendend->descended, descendent, descendant,
+descendents->descendants
 descentences->descendants, descendents,


Travis complains about the inconsistency here, that descendents is listed as an error and a correction

Right.
Line descendents->descendants deleted.

codecov-io · 2019-01-16T17:26:01Z

Codecov Report

Merging #795 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #795   +/-   ##
=======================================
  Coverage   90.92%   90.92%           
=======================================
  Files           4        4           
  Lines         727      727           
  Branches      106      106           
=======================================
  Hits          661      661           
  Misses         48       48           
  Partials       18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c241fa...f09a043. Read the comment docs.

larsoner · 2019-01-17T15:09:59Z

codespell_lib/data/dictionary.txt

@@ -13401,6 +13431,7 @@ theres->there's
 therfore->therefore
 theri->their, there,
 thes->this, these,
+theses->these, thesis,


theses is the plural of thesis so should be allowed as a correction

Don't we normally remove them if the incorrect word is actually valid?

Sometimes yes, sometimes no. Depends on the likely balance of false alarms and misses

That should probably be another bit in the bitmask:
#410 (comment)

Looks the same as the other cases we were talking about there, so I still only see a need for 0/1 so far

Ah, maybe I was thinking of "disabled due to" instead.

Typos from the OCaml language

f90536f

luzpaz reviewed Jan 12, 2019

View reviewed changes

Update dictionary.txt

8673a09

OK. Line deleted.

luzpaz approved these changes Jan 12, 2019

View reviewed changes

peternewman requested changes Jan 16, 2019

View reviewed changes

Update dictionary.txt

28068a8

peternewman approved these changes Jan 16, 2019

View reviewed changes

larsoner reviewed Jan 16, 2019

View reviewed changes

Update dictionary.txt

b0f4880

larsoner reviewed Jan 17, 2019

View reviewed changes

larsoner added 2 commits January 17, 2019 10:10

FIX: Theses is valid

c149d39

Update dictionary.txt

f09a043

larsoner merged commit ee2cc71 into codespell-project:master Jan 17, 2019

Fourchaux mentioned this pull request Feb 12, 2019

Fixing typos in various files ocaml/ocaml#2246

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Typos from the OCaml language #795

Typos from the OCaml language #795

Fourchaux commented Jan 8, 2019

luzpaz Jan 12, 2019 •

edited

Loading

luzpaz commented Jan 12, 2019

larsoner commented Jan 12, 2019

peternewman left a comment

peternewman Jan 16, 2019

Fourchaux Jan 16, 2019

peternewman Jan 16, 2019

Fourchaux Jan 16, 2019

peternewman Jan 16, 2019

Fourchaux Jan 16, 2019

peternewman Jan 16, 2019

Fourchaux Jan 16, 2019

peternewman Jan 16, 2019

Fourchaux Jan 16, 2019

peternewman Jan 16, 2019

Fourchaux Jan 16, 2019

peternewman Jan 16, 2019

Fourchaux Jan 16, 2019

peternewman Jan 16, 2019

Fourchaux Jan 16, 2019

peternewman Jan 16, 2019

Fourchaux Jan 16, 2019

peternewman left a comment

larsoner Jan 16, 2019

Fourchaux Jan 16, 2019

codecov-io commented Jan 16, 2019 •

edited

Loading

larsoner Jan 17, 2019

peternewman Jan 17, 2019

larsoner Jan 17, 2019

peternewman Jan 17, 2019

larsoner Jan 17, 2019

peternewman Jan 17, 2019

Typos from the OCaml language #795

Typos from the OCaml language #795

Conversation

Fourchaux commented Jan 8, 2019

luzpaz Jan 12, 2019 • edited Loading

Choose a reason for hiding this comment

luzpaz commented Jan 12, 2019

larsoner commented Jan 12, 2019

peternewman left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

peternewman left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Jan 16, 2019 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luzpaz Jan 12, 2019 •

edited

Loading

codecov-io commented Jan 16, 2019 •

edited

Loading