Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Assign Honor Points for Translation Approval #1518

Open
nomennescio opened this issue Jul 28, 2018 · 6 comments
Open

Feature request: Assign Honor Points for Translation Approval #1518

nomennescio opened this issue Jul 28, 2018 · 6 comments
Labels
area/translation kind/feature-request Use this when the request includes specific feature. Otherwise, use generic enhancement.

Comments

@nomennescio
Copy link

nomennescio commented Jul 28, 2018

The long-standing issue of unapproved translations is still not moving forward. Suggestions to use e.g. gitter.me to request translation approval are not really working.

Therefore this feature request. As everything in the Codewars universe is driven by Honor points, and even trivial actions like comment upvoting will earn you these, I propose to assign honor points for approval of a translation. I expect that this will help to get more translations approved and that are currently months or years waiting for their approval. It is a simple solution and I expect it will not require much effort to implement.

How much points? Well, I would say that as approving involves some work as to valuing the test code, running code to see if it passes, and determining if the translation behaves the same as the original code, it is probable fair to couple it to the level of the Kata. Currently Honor points are rewarded for the translation itself (which obviously involves a lot more work) as follows:

Activity Honor Points
Translation Approved (White) 4
Translation Approved (Yellow) 16  
Translation Approved (Blue) 64  
Translation Approved (Purple) 256

and a trivial action like comment upvoting earns 1 Honor Point, I would therefore suggest the following

Activity Honor Points
Translation Approval (White) 2
Translation Approval (Yellow) 4  
Translation Approval (Blue) 6  
Translation Approval (Purple) 8

┆Issue is synchronized with this Clickup by Unito

@FArekkusu
Copy link

FArekkusu commented Jul 28, 2018

I would say that as approving involves some work as to valuing the test code, running code to see if it passes, and determining if the translation behaves the same as the original code, it is probable fair to couple it to the level of the Kata.

Or I can press "Approve" without even looking. Considering the public belief that the translator will come and fix what is broken, this actually happens on CW from time to time.

Approval: (white) - 2, (yellow) - 4, (blue) - 6, (purple) - 8

Didn't you just say that approving translation may be as hard as solving the kata? Instead of giving the user very few points, translation approval should reward the user with at least the same amount of honor because you have to carefully check the other user's code, check the original test cases, compare them. thoroughly test everything, determine if the code is working correctly... (aren't these the things the translator has to do himself?)

@nomennescio
Copy link
Author

I would be totally OK with the translator be able to approve his own translation and be responsible for it. Unfortunately, that is not the case, and translations pending approval pile up, some for more than a year. There is currently no mechanism to trigger approval, hence the proposal.

And no, I did not say that approving is as hard as solving. You need to check the translation passes all tests, and that the test are (near) identical to the original tests.

@kazk kazk added the kind/feature-request Use this when the request includes specific feature. Otherwise, use generic enhancement. label Jul 29, 2018
@dinglemouse2250
Copy link

Pressing "Approve" without knowing exactly what you are approving is irresponsible. Junk will creep in, and the Kata rating will suffer.

Nobody but the sensei should ever be allowed to approve a translation. (Exception only if sensei is inactive > 1 month). In particular, allowing a translator to approve their own translations is just asking for trouble.

For example, I won't approve anything unless it meets my standards, and mimics my original in every way possible. Sure, it upsets some translators to be rejected, but those are people who don't realize that a sloppy translation can easily harm the satisfaction of the original Kata. Therefore: My Kata = My approval rules,

I agree with the original proposal. Verifying takes some effort... it deserves some points as incentive/reward.

@nomennescio
Copy link
Author

nomennescio commented Jul 30, 2018

I'm totally fine to restrict approving the translation of the Kata to the author of the Kata, with the exception that the many pending translated Katas show the author is inactive or is not interested anymore. To that end currently it is already possible for people with sufficient high honor points to approve translations under certain conditions. Therefore the rewarding of approvals should extend to these people once they are able to approve. The conditions already erected a barrier against careless approvals.

@hobovsky
Copy link

hobovsky commented Aug 3, 2018

Maybe it could be helped in another than honor-based way? For example, provide users with a view, like "Translations for approval", where eligible users (for example, power users) could easily see translations which are there older than X days/months for katas abandoned by author and whatever conditions you like. IMO main problem is not lack of/insufficient reward for approval of pending translation, but the difficulty of even finding one. Just provide a convenient way of searching for pending translations and people will search for them.

@anter69
Copy link

anter69 commented Aug 9, 2018

For example, provide users with a view, like "Translations for approval", where eligible users (for example, power users) could easily see translations which are there older than X days/months for katas abandoned by author and whatever conditions you like

See #1431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/translation kind/feature-request Use this when the request includes specific feature. Otherwise, use generic enhancement.
Projects
None yet
Development

No branches or pull requests

6 participants