pass options on removeEventListener (#904)

* pass options on removeEventListener by removeAll * rebuild * Merge branch 'release/2.16' into pr/904 * Update CHANGELOG.md * Update inline.ts
codex-team · Nov 30, 2019 · 729f2ea · 729f2ea
1 parent fa4b282
commit 729f2ea
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/dist/editor.js b/dist/editor.js
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -11,6 +11,7 @@
 — `Fix` — Fix flipper with empty dom iterator [#926](https://github.com/codex-team/editor.js/issues/926)
 - `Fix` — Normalize node before walking through children at `isEmpty` method [943](https://github.com/codex-team/editor.js/issues/943)
 — `Fix` — Fixed Grammarly conflict [#779](https://github.com/codex-team/editor.js/issues/779)
+— `Improvements` — Module Listeners now correctly removes events with options [#904](https://github.com/codex-team/editor.js/pull/904)
 — `Fix` — Fixed History Back on block deletion by Backspace in Firefox [#967](https://github.com/codex-team/editor.js/pull/967)
 
 ### 2.15.1

diff --git a/src/components/modules/listeners.ts b/src/components/modules/listeners.ts
@@ -145,7 +145,7 @@ export default class Listeners extends Module {
    */
   public removeAll(): void {
     this.allListeners.map( (current) => {
-      current.element.removeEventListener(current.eventType, current.handler);
+      current.element.removeEventListener(current.eventType, current.handler, current.options);
     });
 
     this.allListeners = [];