Release: 2.19 #1341

neSpecc · 2020-10-05T16:35:35Z

New - Read-only mode 🥳 #837
New - RTL mode added #670
Fix — Fix problem with types usage #1183
Fix - Fixed issue with Spam clicking the "Click to tune" button duplicates the icons on FireFox. #1273
Fix - Fixed issue with editor.blocks.delete(index) method which throws an error when Editor.js is not focused, even after providing a valid index. #1182
Improvements - The initialBlock property of Editor config is deprecated. Use the defaultBlock instead. #993
Fix - Fixed the issue of toolbar not disappearing on entering input in Chinese, Hindi and some other languages. #1196
Improvements - BlockAPI call() method now returns the result of calling method, thus allowing it to expose arbitrary data as needed #1205
Improvements - Unuseful log about missed i18n section has been removed #1269
Fix - Do not stop events propagation if not needed (essential for React synthetic events) #1051 #946
Fix - Tool's destroy method is not invoked when editor.destroy() is called. #1047
New - Tool's reset static method added to the API to clean up any data added by Tool on initialization
Improvements - Unuseful log about missed i18n section has been removed #1269
Fix - Fixed issue with enter key in inputs and textareas #920
Improvements - Allowed to set false as toolbox config in order to hide Toolbox button #1221
New - Allows users to provide common inlineToolbar property which will be used for all tools whose inlineToolbar property is set to true. It can be overridden by the tool's own inlineToolbar property. Also, inline tools will be ordered according to the order of the inline tools in array provided in the inlineToolbar property. #1056
Fix - blocks.getBlockByIndex() API method now returns void for indexes out of range #1270
Fix - Fixed the onChange callback issue. This method didn't be called for native inputs before some contentedtable element changed #843

* [Improvements] ESLint action (#1099) * TSLint -> ESLint, GitHub Action * Update eslint.yml * Autofix * more autofix * fix * manually fix some issues * Update CHANGELOG.md * [Refactor] ESLint fixed (#1100) Co-authored-by: Peter Savchenko <[email protected]> * [Feature] i18n (#1106) * i18n first steps * i18n internal, toolbox, api for tools * namespaced api * tn, t * tn in block tunes * join toolbox and inlineTools under toolNames * translations * make enum toolTypes * Update block.ts * Update src/components/core.ts Co-Authored-By: George Berezhnoy <[email protected]> * add more types * rm tn * export i18n types * upd bundle * fix tabulation * Add type-safe namespaces * upd * Improve example * Update toolbox.ts * improve examplle * upd * fix typo * Add comments for complex types Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> * Remove unused submodule * Fixed: icon centering in Firefox * Do not load styles twice (#1112) * Do not load styles twice * Add changelog * Fix issue link Co-authored-by: Peter Savchenko <[email protected]> * Show warning if Block to delete is not found (#1111) Resolves #1102 * Save Tools' order in the Toolbox (#1113) Resolves #1073 * fix $.isEmpty performance (#1096) * fix $.isEmpty performance * add changelog * upd bundle Co-authored-by: Peter Savchenko <[email protected]> * Add issue templates (#1114) * Update issue templates (#1121) * Update issue templates * Apply suggestions from code review Co-Authored-By: George Berezhnoy <[email protected]> * upd texts * Update feature_request.md * Update .github/ISSUE_TEMPLATE/discussion.md Co-Authored-By: George Berezhnoy <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * Allowing deleting block by block id (#1108) * Allowing deleting block by block id * Fixed no argument error * Making index value optional for delete operation * Added to changelog * Making index value optional for delete operation * Added parameter description * Update docs/CHANGELOG.md * Update types/api/blocks.d.ts * Update editor.js Co-authored-by: Peter Savchenko <[email protected]> * Allow navigate next from last non-initial block (#1110) Resolves #1103 * Create CODE_OF_CONDUCT.md (#1171) * Create CODE_OF_CONDUCT.md * Update changelog file * Update dependencies (#1122) * Update dependencies * upd codex.tooltip * Update editor.js.LICENSE.txt Co-authored-by: Peter Savchenko <[email protected]> * Feature/disable tab event config (#1164) * Highlight first block on autofocus (#1127) * Fix shortcut for external tools (#1141) * fix/shortcut-for-external-tools * Check inline tools property for shortcut Co-authored-by: George Berezhnoy <[email protected]> * Hotfix/issue1133 selection shortcut removed on editor destroy (#1140) * Removed shortcut CMD+A on editor destroy #1133 * Removed patch version and made code cleaner #1133 * lint error fixes #1133 Co-authored-by: Sisir <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * [Feature] BlockAPI Interface (#1075) * Fix BlockManager.insert method (#1172) * Fix BlockManager.insert method * upd * Explicitly check for undefined * Update tools master branches (#1180) * Update master branches * Update image * Update CHANGELOG.md * Fix behaviour of inputs editing in block settings (#1123) * lint code * Update CHANGELOG.md * Return the result of block.call This change allows blocks to return the result of `call` methods, thus allowing them to expose arbitrary data as needed. My particular use case is I am using Vue to mount components inside of the larger editorjs framework. One of the components that we are developing can be thought of as a nested agenda, where labels need to be in an order like: ``` I. Top level a. second level i. third level ``` My plan is to have an orchestrator query all blocks, filter those that need labels prepended, and then programmatically tell each block (with another `call` method) to set its depth to the desired level. At that point, Vue can reactively update any labels, etc. that are needed. I believe this change will allow for other such uses, and I imagine it should not break any existing code since it was returning `null` before. * Disable ESLint for call method return value Because we are returning the value of an arbitrary function, the return value can be anything (hence, the return type must be `any`). However, to reduce noise in ESLint output, we disable ESLint checking the line with the `any` type return. * Change any type to unknown and add to CHANGELOG.md Change any type of the call method to unknown but eslint shows error saying the unknown type is undefined, Also, add the chnage to CHANGELOG.md as an improvement with the link to the PR itself as no issue was assigned with it. * Add unknown to eslint globals * upd Co-authored-by: Peter Savchenko <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> Co-authored-by: tasuku-s <[email protected]> Co-authored-by: Athul Anil Kumar <[email protected]> Co-authored-by: Taly <[email protected]> Co-authored-by: flaming-cl <[email protected]> Co-authored-by: Nguyen Ngoc Son <[email protected]> Co-authored-by: Sisir Das K <[email protected]> Co-authored-by: Sisir <[email protected]> Co-authored-by: ranemihir <[email protected]>

* [Improvements] ESLint action (#1099) * TSLint -> ESLint, GitHub Action * Update eslint.yml * Autofix * more autofix * fix * manually fix some issues * Update CHANGELOG.md * [Refactor] ESLint fixed (#1100) Co-authored-by: Peter Savchenko <[email protected]> * [Feature] i18n (#1106) * i18n first steps * i18n internal, toolbox, api for tools * namespaced api * tn, t * tn in block tunes * join toolbox and inlineTools under toolNames * translations * make enum toolTypes * Update block.ts * Update src/components/core.ts Co-Authored-By: George Berezhnoy <[email protected]> * add more types * rm tn * export i18n types * upd bundle * fix tabulation * Add type-safe namespaces * upd * Improve example * Update toolbox.ts * improve examplle * upd * fix typo * Add comments for complex types Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> * Remove unused submodule * Fixed: icon centering in Firefox * Do not load styles twice (#1112) * Do not load styles twice * Add changelog * Fix issue link Co-authored-by: Peter Savchenko <[email protected]> * Show warning if Block to delete is not found (#1111) Resolves #1102 * Save Tools' order in the Toolbox (#1113) Resolves #1073 * fix $.isEmpty performance (#1096) * fix $.isEmpty performance * add changelog * upd bundle Co-authored-by: Peter Savchenko <[email protected]> * Add issue templates (#1114) * Update issue templates (#1121) * Update issue templates * Apply suggestions from code review Co-Authored-By: George Berezhnoy <[email protected]> * upd texts * Update feature_request.md * Update .github/ISSUE_TEMPLATE/discussion.md Co-Authored-By: George Berezhnoy <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * Allowing deleting block by block id (#1108) * Allowing deleting block by block id * Fixed no argument error * Making index value optional for delete operation * Added to changelog * Making index value optional for delete operation * Added parameter description * Update docs/CHANGELOG.md * Update types/api/blocks.d.ts * Update editor.js Co-authored-by: Peter Savchenko <[email protected]> * Allow navigate next from last non-initial block (#1110) Resolves #1103 * Create CODE_OF_CONDUCT.md (#1171) * Create CODE_OF_CONDUCT.md * Update changelog file * Update dependencies (#1122) * Update dependencies * upd codex.tooltip * Update editor.js.LICENSE.txt Co-authored-by: Peter Savchenko <[email protected]> * Feature/disable tab event config (#1164) * Highlight first block on autofocus (#1127) * Fix shortcut for external tools (#1141) * fix/shortcut-for-external-tools * Check inline tools property for shortcut Co-authored-by: George Berezhnoy <[email protected]> * Hotfix/issue1133 selection shortcut removed on editor destroy (#1140) * Removed shortcut CMD+A on editor destroy #1133 * Removed patch version and made code cleaner #1133 * lint error fixes #1133 Co-authored-by: Sisir <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * [Feature] BlockAPI Interface (#1075) * Fix BlockManager.insert method (#1172) * Fix BlockManager.insert method * upd * Explicitly check for undefined * Update tools master branches (#1180) * Update master branches * Update image * Update CHANGELOG.md * Fix behaviour of inputs editing in block settings (#1123) * lint code * Update CHANGELOG.md * <fix> toolbar overlap with text * Add Fix in CHANGELOG.md * Update editor.js Co-authored-by: Peter Savchenko <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> Co-authored-by: tasuku-s <[email protected]> Co-authored-by: Athul Anil Kumar <[email protected]> Co-authored-by: Taly <[email protected]> Co-authored-by: Nguyen Ngoc Son <[email protected]> Co-authored-by: Sisir Das K <[email protected]> Co-authored-by: Sisir <[email protected]> Co-authored-by: ranemihir <[email protected]>

* [Improvements] ESLint action (#1099) * TSLint -> ESLint, GitHub Action * Update eslint.yml * Autofix * more autofix * fix * manually fix some issues * Update CHANGELOG.md * [Refactor] ESLint fixed (#1100) Co-authored-by: Peter Savchenko <[email protected]> * [Feature] i18n (#1106) * i18n first steps * i18n internal, toolbox, api for tools * namespaced api * tn, t * tn in block tunes * join toolbox and inlineTools under toolNames * translations * make enum toolTypes * Update block.ts * Update src/components/core.ts Co-Authored-By: George Berezhnoy <[email protected]> * add more types * rm tn * export i18n types * upd bundle * fix tabulation * Add type-safe namespaces * upd * Improve example * Update toolbox.ts * improve examplle * upd * fix typo * Add comments for complex types Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> * Remove unused submodule * Fixed: icon centering in Firefox * Do not load styles twice (#1112) * Do not load styles twice * Add changelog * Fix issue link Co-authored-by: Peter Savchenko <[email protected]> * Show warning if Block to delete is not found (#1111) Resolves #1102 * Save Tools' order in the Toolbox (#1113) Resolves #1073 * fix $.isEmpty performance (#1096) * fix $.isEmpty performance * add changelog * upd bundle Co-authored-by: Peter Savchenko <[email protected]> * Add issue templates (#1114) * Update issue templates (#1121) * Update issue templates * Apply suggestions from code review Co-Authored-By: George Berezhnoy <[email protected]> * upd texts * Update feature_request.md * Update .github/ISSUE_TEMPLATE/discussion.md Co-Authored-By: George Berezhnoy <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * Allowing deleting block by block id (#1108) * Allowing deleting block by block id * Fixed no argument error * Making index value optional for delete operation * Added to changelog * Making index value optional for delete operation * Added parameter description * Update docs/CHANGELOG.md * Update types/api/blocks.d.ts * Update editor.js Co-authored-by: Peter Savchenko <[email protected]> * Allow navigate next from last non-initial block (#1110) Resolves #1103 * Create CODE_OF_CONDUCT.md (#1171) * Create CODE_OF_CONDUCT.md * Update changelog file * Update dependencies (#1122) * Update dependencies * upd codex.tooltip * Update editor.js.LICENSE.txt Co-authored-by: Peter Savchenko <[email protected]> * Feature/disable tab event config (#1164) * Highlight first block on autofocus (#1127) * Fix shortcut for external tools (#1141) * fix/shortcut-for-external-tools * Check inline tools property for shortcut Co-authored-by: George Berezhnoy <[email protected]> * Hotfix/issue1133 selection shortcut removed on editor destroy (#1140) * Removed shortcut CMD+A on editor destroy #1133 * Removed patch version and made code cleaner #1133 * lint error fixes #1133 Co-authored-by: Sisir <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * [Feature] BlockAPI Interface (#1075) * Fix BlockManager.insert method (#1172) * Fix BlockManager.insert method * upd * Explicitly check for undefined * Update tools master branches (#1180) * Update master branches * Update image * Update CHANGELOG.md * Fix behaviour of inputs editing in block settings (#1123) * lint code * Update CHANGELOG.md * Rename initialBlock to defaultBlock Closes #993 The initialBlock property is renamed to defaultBlock. * Change keyword 'InitialBlock' to 'DefaultBlock' in all methods Fixes #993 All the methods using the keyword 'Initial' or 'initial' for initial block are replace with 'Default' or 'default'. For example, the Tools.isIntitial() method is changed to Tools.isDefault(). * Keep initialBlock and defaultBlock both. initialBlock property is still kept but it will deprecated in the next major release. * Change defaultBlock in example.html and rebuild. * Remove package-lock.json file. * Update docs/tools.md Co-authored-by: Peter Savchenko <[email protected]> * Update example/example-dev.html Co-authored-by: Peter Savchenko <[email protected]> * Update example/example.html Co-authored-by: Peter Savchenko <[email protected]> * Update example/example-dev.html Co-authored-by: Peter Savchenko <[email protected]> * Update example/example.html Co-authored-by: Peter Savchenko <[email protected]> * Update src/components/utils.ts Co-authored-by: Peter Savchenko <[email protected]> * Update src/components/utils.ts Co-authored-by: Peter Savchenko <[email protected]> * Update types/configs/editor-config.d.ts Co-authored-by: Peter Savchenko <[email protected]> * Update types/configs/editor-config.d.ts Co-authored-by: Peter Savchenko <[email protected]> * Update src/components/utils.ts Co-authored-by: Peter Savchenko <[email protected]> * Fix needAddDefaultBlock to needToAddDefaultBlock * Add as an Improvement to CHANGELOG.md * Delete editor.js.map * fix log, rename some more places * Update example.html * Update blockManager.ts Co-authored-by: Peter Savchenko <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> Co-authored-by: tasuku-s <[email protected]> Co-authored-by: Athul Anil Kumar <[email protected]> Co-authored-by: Taly <[email protected]> Co-authored-by: flaming-cl <[email protected]> Co-authored-by: Nguyen Ngoc Son <[email protected]> Co-authored-by: Sisir Das K <[email protected]> Co-authored-by: Sisir <[email protected]>

* [Improvements] ESLint action (#1099) * TSLint -> ESLint, GitHub Action * Update eslint.yml * Autofix * more autofix * fix * manually fix some issues * Update CHANGELOG.md * [Refactor] ESLint fixed (#1100) Co-authored-by: Peter Savchenko <[email protected]> * [Feature] i18n (#1106) * i18n first steps * i18n internal, toolbox, api for tools * namespaced api * tn, t * tn in block tunes * join toolbox and inlineTools under toolNames * translations * make enum toolTypes * Update block.ts * Update src/components/core.ts Co-Authored-By: George Berezhnoy <[email protected]> * add more types * rm tn * export i18n types * upd bundle * fix tabulation * Add type-safe namespaces * upd * Improve example * Update toolbox.ts * improve examplle * upd * fix typo * Add comments for complex types Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> * Remove unused submodule * Fixed: icon centering in Firefox * Do not load styles twice (#1112) * Do not load styles twice * Add changelog * Fix issue link Co-authored-by: Peter Savchenko <[email protected]> * Show warning if Block to delete is not found (#1111) Resolves #1102 * Save Tools' order in the Toolbox (#1113) Resolves #1073 * fix $.isEmpty performance (#1096) * fix $.isEmpty performance * add changelog * upd bundle Co-authored-by: Peter Savchenko <[email protected]> * Add issue templates (#1114) * Update issue templates (#1121) * Update issue templates * Apply suggestions from code review Co-Authored-By: George Berezhnoy <[email protected]> * upd texts * Update feature_request.md * Update .github/ISSUE_TEMPLATE/discussion.md Co-Authored-By: George Berezhnoy <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * Allowing deleting block by block id (#1108) * Allowing deleting block by block id * Fixed no argument error * Making index value optional for delete operation * Added to changelog * Making index value optional for delete operation * Added parameter description * Update docs/CHANGELOG.md * Update types/api/blocks.d.ts * Update editor.js Co-authored-by: Peter Savchenko <[email protected]> * Allow navigate next from last non-initial block (#1110) Resolves #1103 * Create CODE_OF_CONDUCT.md (#1171) * Create CODE_OF_CONDUCT.md * Update changelog file * Update dependencies (#1122) * Update dependencies * upd codex.tooltip * Update editor.js.LICENSE.txt Co-authored-by: Peter Savchenko <[email protected]> * Feature/disable tab event config (#1164) * Highlight first block on autofocus (#1127) * Fix shortcut for external tools (#1141) * fix/shortcut-for-external-tools * Check inline tools property for shortcut Co-authored-by: George Berezhnoy <[email protected]> * Hotfix/issue1133 selection shortcut removed on editor destroy (#1140) * Removed shortcut CMD+A on editor destroy #1133 * Removed patch version and made code cleaner #1133 * lint error fixes #1133 Co-authored-by: Sisir <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * [Feature] BlockAPI Interface (#1075) * Fix BlockManager.insert method (#1172) * Fix BlockManager.insert method * upd * Explicitly check for undefined * Update tools master branches (#1180) * Update master branches * Update image * Update CHANGELOG.md * Fix behaviour of inputs editing in block settings (#1123) * lint code * Update CHANGELOG.md * fix: blocks.delete with undefined index (#1182) * Add as a Fix in CHANGELOG.md. * Update editor.js Co-authored-by: Peter Savchenko <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> Co-authored-by: tasuku-s <[email protected]> Co-authored-by: Athul Anil Kumar <[email protected]> Co-authored-by: Taly <[email protected]> Co-authored-by: flaming-cl <[email protected]> Co-authored-by: Nguyen Ngoc Son <[email protected]> Co-authored-by: Sisir Das K <[email protected]> Co-authored-by: Sisir <[email protected]> Co-authored-by: ranemihir <[email protected]>

* Fix spam cliclikng tune in Firefox #1273 * build

* The unwanted I18n messages from console is disabled * Update docs/CHANGELOG.md Improved Change log Co-authored-by: Peter Savchenko <[email protected]> * Remove import statement import * as _ from '../utils'; removed * Apply suggestions from code review Co-authored-by: Peter Savchenko <[email protected]> Co-authored-by: Peter Savchenko <[email protected]>

* Move SavedData and ValidatedData interfaces from internal types * Add changelog

* upd modules * Revert "upd modules" This reverts commit e2ff850. * upd modules

* Tools destroy called when the editor is destroyed When the editor instance is destroyed, it calls the destroy of the blockManager. blockManager inturn calls destroy of all the blocks that it manages. * Fixed lint errors * Use Prmoise.all and add as a Fix in CHANGELOG.md * Fix commit * Fix CHANGELOG.md * Add call of Tools reset methods * Update tools * Update changelog * Update docs/CHANGELOG.md Co-authored-by: Peter Savchenko <[email protected]> * upd all * bundle * upd tools Co-authored-by: ranemihir <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Peter Savchenko <[email protected]>

Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.2...v6.5.3) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [Improvements] ESLint action (#1099) * TSLint -> ESLint, GitHub Action * Update eslint.yml * Autofix * more autofix * fix * manually fix some issues * Update CHANGELOG.md * [Refactor] ESLint fixed (#1100) Co-authored-by: Peter Savchenko <[email protected]> * [Feature] i18n (#1106) * i18n first steps * i18n internal, toolbox, api for tools * namespaced api * tn, t * tn in block tunes * join toolbox and inlineTools under toolNames * translations * make enum toolTypes * Update block.ts * Update src/components/core.ts Co-Authored-By: George Berezhnoy <[email protected]> * add more types * rm tn * export i18n types * upd bundle * fix tabulation * Add type-safe namespaces * upd * Improve example * Update toolbox.ts * improve examplle * upd * fix typo * Add comments for complex types Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> * Remove unused submodule * Fixed: icon centering in Firefox * Do not load styles twice (#1112) * Do not load styles twice * Add changelog * Fix issue link Co-authored-by: Peter Savchenko <[email protected]> * Show warning if Block to delete is not found (#1111) Resolves #1102 * Save Tools' order in the Toolbox (#1113) Resolves #1073 * fix $.isEmpty performance (#1096) * fix $.isEmpty performance * add changelog * upd bundle Co-authored-by: Peter Savchenko <[email protected]> * Add issue templates (#1114) * Update issue templates (#1121) * Update issue templates * Apply suggestions from code review Co-Authored-By: George Berezhnoy <[email protected]> * upd texts * Update feature_request.md * Update .github/ISSUE_TEMPLATE/discussion.md Co-Authored-By: George Berezhnoy <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * Allowing deleting block by block id (#1108) * Allowing deleting block by block id * Fixed no argument error * Making index value optional for delete operation * Added to changelog * Making index value optional for delete operation * Added parameter description * Update docs/CHANGELOG.md * Update types/api/blocks.d.ts * Update editor.js Co-authored-by: Peter Savchenko <[email protected]> * Allow navigate next from last non-initial block (#1110) Resolves #1103 * Create CODE_OF_CONDUCT.md (#1171) * Create CODE_OF_CONDUCT.md * Update changelog file * Update dependencies (#1122) * Update dependencies * upd codex.tooltip * Update editor.js.LICENSE.txt Co-authored-by: Peter Savchenko <[email protected]> * Feature/disable tab event config (#1164) * Highlight first block on autofocus (#1127) * Fix shortcut for external tools (#1141) * fix/shortcut-for-external-tools * Check inline tools property for shortcut Co-authored-by: George Berezhnoy <[email protected]> * Hotfix/issue1133 selection shortcut removed on editor destroy (#1140) * Removed shortcut CMD+A on editor destroy #1133 * Removed patch version and made code cleaner #1133 * lint error fixes #1133 Co-authored-by: Sisir <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * [Feature] BlockAPI Interface (#1075) * Fix BlockManager.insert method (#1172) * Fix BlockManager.insert method * upd * Explicitly check for undefined * Update tools master branches (#1180) * Update master branches * Update image * Update CHANGELOG.md * Fix behaviour of inputs editing in block settings (#1123) * lint code * Update CHANGELOG.md * added handling of inputs and textareas in custom plugins * Upd tools * Add changelog * Upd submodules Co-authored-by: Peter Savchenko <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> Co-authored-by: tasuku-s <[email protected]> Co-authored-by: Athul Anil Kumar <[email protected]> Co-authored-by: Taly <[email protected]> Co-authored-by: flaming-cl <[email protected]> Co-authored-by: Nguyen Ngoc Son <[email protected]> Co-authored-by: Sisir Das K <[email protected]> Co-authored-by: Sisir <[email protected]>

…oncept (#1260) * Typos changes. Required to fix them too on the official documentation website * Update README.md Co-authored-by: George Berezhnoy <[email protected]> * Use only import Co-authored-by: Peter Savchenko <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: George Berezhnoy <[email protected]>

* Add hidden option to toolbox * Use false in order to hide toolbox * Add comment what false means * Add issue #1221 to changelog Co-authored-by: t.hata <[email protected]>

* [Improvements] ESLint action (#1099) * TSLint -> ESLint, GitHub Action * Update eslint.yml * Autofix * more autofix * fix * manually fix some issues * Update CHANGELOG.md * [Refactor] ESLint fixed (#1100) Co-authored-by: Peter Savchenko <[email protected]> * [Feature] i18n (#1106) * i18n first steps * i18n internal, toolbox, api for tools * namespaced api * tn, t * tn in block tunes * join toolbox and inlineTools under toolNames * translations * make enum toolTypes * Update block.ts * Update src/components/core.ts Co-Authored-By: George Berezhnoy <[email protected]> * add more types * rm tn * export i18n types * upd bundle * fix tabulation * Add type-safe namespaces * upd * Improve example * Update toolbox.ts * improve examplle * upd * fix typo * Add comments for complex types Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> * Remove unused submodule * Fixed: icon centering in Firefox * Do not load styles twice (#1112) * Do not load styles twice * Add changelog * Fix issue link Co-authored-by: Peter Savchenko <[email protected]> * Show warning if Block to delete is not found (#1111) Resolves #1102 * Save Tools' order in the Toolbox (#1113) Resolves #1073 * fix $.isEmpty performance (#1096) * fix $.isEmpty performance * add changelog * upd bundle Co-authored-by: Peter Savchenko <[email protected]> * Add issue templates (#1114) * Update issue templates (#1121) * Update issue templates * Apply suggestions from code review Co-Authored-By: George Berezhnoy <[email protected]> * upd texts * Update feature_request.md * Update .github/ISSUE_TEMPLATE/discussion.md Co-Authored-By: George Berezhnoy <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * Allowing deleting block by block id (#1108) * Allowing deleting block by block id * Fixed no argument error * Making index value optional for delete operation * Added to changelog * Making index value optional for delete operation * Added parameter description * Update docs/CHANGELOG.md * Update types/api/blocks.d.ts * Update editor.js Co-authored-by: Peter Savchenko <[email protected]> * Allow navigate next from last non-initial block (#1110) Resolves #1103 * Create CODE_OF_CONDUCT.md (#1171) * Create CODE_OF_CONDUCT.md * Update changelog file * Update dependencies (#1122) * Update dependencies * upd codex.tooltip * Update editor.js.LICENSE.txt Co-authored-by: Peter Savchenko <[email protected]> * Feature/disable tab event config (#1164) * Highlight first block on autofocus (#1127) * Fix shortcut for external tools (#1141) * fix/shortcut-for-external-tools * Check inline tools property for shortcut Co-authored-by: George Berezhnoy <[email protected]> * Hotfix/issue1133 selection shortcut removed on editor destroy (#1140) * Removed shortcut CMD+A on editor destroy #1133 * Removed patch version and made code cleaner #1133 * lint error fixes #1133 Co-authored-by: Sisir <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * [Feature] BlockAPI Interface (#1075) * Fix BlockManager.insert method (#1172) * Fix BlockManager.insert method * upd * Explicitly check for undefined * Update tools master branches (#1180) * Update master branches * Update image * Update CHANGELOG.md * Fix behaviour of inputs editing in block settings (#1123) * lint code * Update CHANGELOG.md * Added RTL support * Fixed code style * Fixed icons positioning in the toolbar in the RTL mode * Renamed example-dev-rtl.html to example-rtl.html * Moved 'direction' option to 'i18n' section * Fixed an issue with arrow navigation between blocks * Renamed rtl-fix to codex-editor--rtl * Fixed icons positioning in the narrow mode for RTL * Replaced 'isRtl' method with getter * Fixed bug with the editor initialization when 'i18n' option is not set * narrow mode improved * Changelog added Co-authored-by: Peter Savchenko <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> Co-authored-by: tasuku-s <[email protected]> Co-authored-by: Athul Anil Kumar <[email protected]> Co-authored-by: Taly <[email protected]> Co-authored-by: flaming-cl <[email protected]> Co-authored-by: Nguyen Ngoc Son <[email protected]> Co-authored-by: Sisir Das K <[email protected]> Co-authored-by: Sisir <[email protected]> Co-authored-by: ImangazalievM <[email protected]>

* Fix i18n default configuration * update bundle

* Fixing Bug #1270 and resolve all yarn lint warning. * Update CHANGELOG.md * Change the Log type from Error to Warn * upd types Co-authored-by: Peter Savchenko <[email protected]>

* Fixing: #843 problem with onchange callback * Update docs/CHANGELOG.md Co-authored-by: Peter Savchenko <[email protected]> Co-authored-by: Peter Savchenko <[email protected]>

(ﾉ◕ヮ◕)ﾉ*:･ﾟ✧

* Add inlineToolbar property * Fix lint errors * Fix comments Co-authored-by: Murod Khaydarov <[email protected]> * Sort Tools Working, Can be optimized further * Fix dataset error and use children * Fix lint errors * Add as improvement to CHNAGELOG.md * Fix comments Co-authored-by: Peter Savchenko <[email protected]> * Add comments and small fixes * Fix lint errors * Fix sortTools() and check inlineToolbar property * Fix lint errors * Fix conditions and property names * Separate block toggler from buttons list in ui * Fix lint errors * Fix condition names in allowedToShow() * Minor bug fixes * Fix linter warnings * Update docs/CHANGELOG.md Co-authored-by: Murod Khaydarov <[email protected]> * create inlineToolbarSettings() method * Minor fixes * Clearify boolean casting * upd bundle * fix getInlineToolbarSettings * refactor & create new instance every showing * remove unused codee Co-authored-by: Murod Khaydarov <[email protected]> Co-authored-by: Peter Savchenko <[email protected]>

* Throw error only if read-only is enabled from the start * update modules

* Fixed the 1302 bug and improve the tab key behaviour * yarn lint:fixed based improvements * Update docs/CHANGELOG.md Co-authored-by: Peter Savchenko <[email protected]> * Update src/components/modules/ui.ts Co-authored-by: Peter Savchenko <[email protected]> Co-authored-by: Peter Savchenko <[email protected]>

* Fix caret behaviour * Fix current input update

* Toggle readonly on start * Do not render block twice on start

* Enable modification observer when onChange callback throws an error * Build * Update src/components/modules/modificationsObserver.ts Co-authored-by: George Berezhnoy <[email protected]> * Update CHANGELOG Co-authored-by: t.hata <[email protected]> Co-authored-by: George Berezhnoy <[email protected]>

* FIx errors on enter press when several blocks selected * Fix for safari

neSpecc

On image pasting by drag-n-drop, it is pasted twice (tested in example-dev in Safari)

neSpecc · 2020-10-08T09:58:43Z

types/tools/block-tool.d.ts

+  /**
+   * @param {boolean} readOnly - render HTML on readonly mode
+   */
+  render(readOnly?: boolean): HTMLElement;


should be removed as not used.

neSpecc · 2020-10-08T10:04:25Z

example/example-dev.html

@@ -34,6 +34,15 @@
      <div class="ce-example__button" id="saveButton">
        editor.save()
      </div>
+      <div class="ce-example__statusbar">


i think, all the changes from example-dev.html should be included to the example.html as well.

neSpecc · 2020-10-08T10:06:10Z

example/example-rtl.html

@@ -0,0 +1,235 @@
+<!--
+ Use this page for debugging purposes.


Suggested change

Use this page for debugging purposes.

Use this page for the debugging of RTL mode.

neSpecc · 2020-10-08T10:06:35Z

example/example-rtl.html

+<html lang="en">
+<head>
+  <meta charset="UTF-8">
+  <title>Editor.js 🤩🧦🤨 example</title>


Suggested change

<title>Editor.js 🤩🧦🤨 example</title>

<title>Editor.js RTL example</title>

neSpecc · 2020-10-08T10:10:01Z

src/components/block-tunes/block-tune-move-down.ts

@@ -84,6 +84,11 @@ export default class MoveDownTune implements BlockTune {
    }

    const nextBlock = this.api.blocks.getBlockByIndex(currentBlockIndex + 1);
+
+    if (!nextBlock) {


how it can happen? This statement is checking above.

neSpecc · 2020-10-08T10:24:38Z

src/components/modules/modificationsObserver.ts

@@ -37,7 +37,10 @@ export default class ModificationsObserver extends Module {
   */
  private mutationDebouncer = _.debounce(() => {
    this.updateNativeInputs();
-    this.config.onChange(this.Editor.API.methods);
+
+    if (typeof this.config.onChange === 'function') {


use utils.isFunction

neSpecc · 2020-10-08T10:29:56Z

src/components/modules/toolbar/index.ts


+  /**
+   * Module preparation method
+   * Steps:


Steps... comment should be moved to the drawUI method

neSpecc · 2020-10-08T10:31:42Z

src/components/modules/tools.ts

@@ -418,7 +444,7 @@ export default class Tools extends Module {
         */
        toolPreparationList.push({
          // eslint-disable-next-line @typescript-eslint/no-empty-function
-          function: typeof toolClass.prepare === 'function' ? toolClass.prepare : (): void => {},
+          function: typeof toolClass.prepare === 'function' ? toolClass.prepare : (): void => { },


utils.isFunction

neSpecc · 2020-10-08T10:35:03Z

types/api/blocks.d.ts

   */
-  render(data: OutputData): Promise<void>;
+  render(data: OutputData, readOnly: boolean): Promise<void>;


does the readOnly here is actually used? For what case?

neSpecc · 2020-10-08T10:36:59Z

types/tools/inline-tool.d.ts

@@ -31,6 +31,8 @@ export interface InlineTool extends BaseTool {

  /**
   * Function called with Inline Toolbar closing
+   * @deprecated 2020 10/02 - The new instance will be created each time the button is rendered. So clear is not needed.


should be added to the changelog.

This reverts commit 7877570.

* Release: 2.19 (#1341) * typo fixed (#1235) * Improvements: more translations added to the i18n example (#1250) * Return the result of block.call (#1205) * [Improvements] ESLint action (#1099) * TSLint -> ESLint, GitHub Action * Update eslint.yml * Autofix * more autofix * fix * manually fix some issues * Update CHANGELOG.md * [Refactor] ESLint fixed (#1100) Co-authored-by: Peter Savchenko <[email protected]> * [Feature] i18n (#1106) * i18n first steps * i18n internal, toolbox, api for tools * namespaced api * tn, t * tn in block tunes * join toolbox and inlineTools under toolNames * translations * make enum toolTypes * Update block.ts * Update src/components/core.ts Co-Authored-By: George Berezhnoy <[email protected]> * add more types * rm tn * export i18n types * upd bundle * fix tabulation * Add type-safe namespaces * upd * Improve example * Update toolbox.ts * improve examplle * upd * fix typo * Add comments for complex types Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> * Remove unused submodule * Fixed: icon centering in Firefox * Do not load styles twice (#1112) * Do not load styles twice * Add changelog * Fix issue link Co-authored-by: Peter Savchenko <[email protected]> * Show warning if Block to delete is not found (#1111) Resolves #1102 * Save Tools' order in the Toolbox (#1113) Resolves #1073 * fix $.isEmpty performance (#1096) * fix $.isEmpty performance * add changelog * upd bundle Co-authored-by: Peter Savchenko <[email protected]> * Add issue templates (#1114) * Update issue templates (#1121) * Update issue templates * Apply suggestions from code review Co-Authored-By: George Berezhnoy <[email protected]> * upd texts * Update feature_request.md * Update .github/ISSUE_TEMPLATE/discussion.md Co-Authored-By: George Berezhnoy <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * Allowing deleting block by block id (#1108) * Allowing deleting block by block id * Fixed no argument error * Making index value optional for delete operation * Added to changelog * Making index value optional for delete operation * Added parameter description * Update docs/CHANGELOG.md * Update types/api/blocks.d.ts * Update editor.js Co-authored-by: Peter Savchenko <[email protected]> * Allow navigate next from last non-initial block (#1110) Resolves #1103 * Create CODE_OF_CONDUCT.md (#1171) * Create CODE_OF_CONDUCT.md * Update changelog file * Update dependencies (#1122) * Update dependencies * upd codex.tooltip * Update editor.js.LICENSE.txt Co-authored-by: Peter Savchenko <[email protected]> * Feature/disable tab event config (#1164) * Highlight first block on autofocus (#1127) * Fix shortcut for external tools (#1141) * fix/shortcut-for-external-tools * Check inline tools property for shortcut Co-authored-by: George Berezhnoy <[email protected]> * Hotfix/issue1133 selection shortcut removed on editor destroy (#1140) * Removed shortcut CMD+A on editor destroy #1133 * Removed patch version and made code cleaner #1133 * lint error fixes #1133 Co-authored-by: Sisir <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * [Feature] BlockAPI Interface (#1075) * Fix BlockManager.insert method (#1172) * Fix BlockManager.insert method * upd * Explicitly check for undefined * Update tools master branches (#1180) * Update master branches * Update image * Update CHANGELOG.md * Fix behaviour of inputs editing in block settings (#1123) * lint code * Update CHANGELOG.md * Return the result of block.call This change allows blocks to return the result of `call` methods, thus allowing them to expose arbitrary data as needed. My particular use case is I am using Vue to mount components inside of the larger editorjs framework. One of the components that we are developing can be thought of as a nested agenda, where labels need to be in an order like: ``` I. Top level a. second level i. third level ``` My plan is to have an orchestrator query all blocks, filter those that need labels prepended, and then programmatically tell each block (with another `call` method) to set its depth to the desired level. At that point, Vue can reactively update any labels, etc. that are needed. I believe this change will allow for other such uses, and I imagine it should not break any existing code since it was returning `null` before. * Disable ESLint for call method return value Because we are returning the value of an arbitrary function, the return value can be anything (hence, the return type must be `any`). However, to reduce noise in ESLint output, we disable ESLint checking the line with the `any` type return. * Change any type to unknown and add to CHANGELOG.md Change any type of the call method to unknown but eslint shows error saying the unknown type is undefined, Also, add the chnage to CHANGELOG.md as an improvement with the link to the PR itself as no issue was assigned with it. * Add unknown to eslint globals * upd Co-authored-by: Peter Savchenko <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> Co-authored-by: tasuku-s <[email protected]> Co-authored-by: Athul Anil Kumar <[email protected]> Co-authored-by: Taly <[email protected]> Co-authored-by: flaming-cl <[email protected]> Co-authored-by: Nguyen Ngoc Son <[email protected]> Co-authored-by: Sisir Das K <[email protected]> Co-authored-by: Sisir <[email protected]> Co-authored-by: ranemihir <[email protected]> * <fix> toolbar--opened overlap with certain text [issue 1196] (#1201) * [Improvements] ESLint action (#1099) * TSLint -> ESLint, GitHub Action * Update eslint.yml * Autofix * more autofix * fix * manually fix some issues * Update CHANGELOG.md * [Refactor] ESLint fixed (#1100) Co-authored-by: Peter Savchenko <[email protected]> * [Feature] i18n (#1106) * i18n first steps * i18n internal, toolbox, api for tools * namespaced api * tn, t * tn in block tunes * join toolbox and inlineTools under toolNames * translations * make enum toolTypes * Update block.ts * Update src/components/core.ts Co-Authored-By: George Berezhnoy <[email protected]> * add more types * rm tn * export i18n types * upd bundle * fix tabulation * Add type-safe namespaces * upd * Improve example * Update toolbox.ts * improve examplle * upd * fix typo * Add comments for complex types Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> * Remove unused submodule * Fixed: icon centering in Firefox * Do not load styles twice (#1112) * Do not load styles twice * Add changelog * Fix issue link Co-authored-by: Peter Savchenko <[email protected]> * Show warning if Block to delete is not found (#1111) Resolves #1102 * Save Tools' order in the Toolbox (#1113) Resolves #1073 * fix $.isEmpty performance (#1096) * fix $.isEmpty performance * add changelog * upd bundle Co-authored-by: Peter Savchenko <[email protected]> * Add issue templates (#1114) * Update issue templates (#1121) * Update issue templates * Apply suggestions from code review Co-Authored-By: George Berezhnoy <[email protected]> * upd texts * Update feature_request.md * Update .github/ISSUE_TEMPLATE/discussion.md Co-Authored-By: George Berezhnoy <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * Allowing deleting block by block id (#1108) * Allowing deleting block by block id * Fixed no argument error * Making index value optional for delete operation * Added to changelog * Making index value optional for delete operation * Added parameter description * Update docs/CHANGELOG.md * Update types/api/blocks.d.ts * Update editor.js Co-authored-by: Peter Savchenko <[email protected]> * Allow navigate next from last non-initial block (#1110) Resolves #1103 * Create CODE_OF_CONDUCT.md (#1171) * Create CODE_OF_CONDUCT.md * Update changelog file * Update dependencies (#1122) * Update dependencies * upd codex.tooltip * Update editor.js.LICENSE.txt Co-authored-by: Peter Savchenko <[email protected]> * Feature/disable tab event config (#1164) * Highlight first block on autofocus (#1127) * Fix shortcut for external tools (#1141) * fix/shortcut-for-external-tools * Check inline tools property for shortcut Co-authored-by: George Berezhnoy <[email protected]> * Hotfix/issue1133 selection shortcut removed on editor destroy (#1140) * Removed shortcut CMD+A on editor destroy #1133 * Removed patch version and made code cleaner #1133 * lint error fixes #1133 Co-authored-by: Sisir <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * [Feature] BlockAPI Interface (#1075) * Fix BlockManager.insert method (#1172) * Fix BlockManager.insert method * upd * Explicitly check for undefined * Update tools master branches (#1180) * Update master branches * Update image * Update CHANGELOG.md * Fix behaviour of inputs editing in block settings (#1123) * lint code * Update CHANGELOG.md * <fix> toolbar overlap with text * Add Fix in CHANGELOG.md * Update editor.js Co-authored-by: Peter Savchenko <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> Co-authored-by: tasuku-s <[email protected]> Co-authored-by: Athul Anil Kumar <[email protected]> Co-authored-by: Taly <[email protected]> Co-authored-by: Nguyen Ngoc Son <[email protected]> Co-authored-by: Sisir Das K <[email protected]> Co-authored-by: Sisir <[email protected]> Co-authored-by: ranemihir <[email protected]> * Rename initialBlock to defaultBlock (#1209) * [Improvements] ESLint action (#1099) * TSLint -> ESLint, GitHub Action * Update eslint.yml * Autofix * more autofix * fix * manually fix some issues * Update CHANGELOG.md * [Refactor] ESLint fixed (#1100) Co-authored-by: Peter Savchenko <[email protected]> * [Feature] i18n (#1106) * i18n first steps * i18n internal, toolbox, api for tools * namespaced api * tn, t * tn in block tunes * join toolbox and inlineTools under toolNames * translations * make enum toolTypes * Update block.ts * Update src/components/core.ts Co-Authored-By: George Berezhnoy <[email protected]> * add more types * rm tn * export i18n types * upd bundle * fix tabulation * Add type-safe namespaces * upd * Improve example * Update toolbox.ts * improve examplle * upd * fix typo * Add comments for complex types Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> * Remove unused submodule * Fixed: icon centering in Firefox * Do not load styles twice (#1112) * Do not load styles twice * Add changelog * Fix issue link Co-authored-by: Peter Savchenko <[email protected]> * Show warning if Block to delete is not found (#1111) Resolves #1102 * Save Tools' order in the Toolbox (#1113) Resolves #1073 * fix $.isEmpty performance (#1096) * fix $.isEmpty performance * add changelog * upd bundle Co-authored-by: Peter Savchenko <[email protected]> * Add issue templates (#1114) * Update issue templates (#1121) * Update issue templates * Apply suggestions from code review Co-Authored-By: George Berezhnoy <[email protected]> * upd texts * Update feature_request.md * Update .github/ISSUE_TEMPLATE/discussion.md Co-Authored-By: George Berezhnoy <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * Allowing deleting block by block id (#1108) * Allowing deleting block by block id * Fixed no argument error * Making index value optional for delete operation * Added to changelog * Making index value optional for delete operation * Added parameter description * Update docs/CHANGELOG.md * Update types/api/blocks.d.ts * Update editor.js Co-authored-by: Peter Savchenko <[email protected]> * Allow navigate next from last non-initial block (#1110) Resolves #1103 * Create CODE_OF_CONDUCT.md (#1171) * Create CODE_OF_CONDUCT.md * Update changelog file * Update dependencies (#1122) * Update dependencies * upd codex.tooltip * Update editor.js.LICENSE.txt Co-authored-by: Peter Savchenko <[email protected]> * Feature/disable tab event config (#1164) * Highlight first block on autofocus (#1127) * Fix shortcut for external tools (#1141) * fix/shortcut-for-external-tools * Check inline tools property for shortcut Co-authored-by: George Berezhnoy <[email protected]> * Hotfix/issue1133 selection shortcut removed on editor destroy (#1140) * Removed shortcut CMD+A on editor destroy #1133 * Removed patch version and made code cleaner #1133 * lint error fixes #1133 Co-authored-by: Sisir <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * [Feature] BlockAPI Interface (#1075) * Fix BlockManager.insert method (#1172) * Fix BlockManager.insert method * upd * Explicitly check for undefined * Update tools master branches (#1180) * Update master branches * Update image * Update CHANGELOG.md * Fix behaviour of inputs editing in block settings (#1123) * lint code * Update CHANGELOG.md * Rename initialBlock to defaultBlock Closes #993 The initialBlock property is renamed to defaultBlock. * Change keyword 'InitialBlock' to 'DefaultBlock' in all methods Fixes #993 All the methods using the keyword 'Initial' or 'initial' for initial block are replace with 'Default' or 'default'. For example, the Tools.isIntitial() method is changed to Tools.isDefault(). * Keep initialBlock and defaultBlock both. initialBlock property is still kept but it will deprecated in the next major release. * Change defaultBlock in example.html and rebuild. * Remove package-lock.json file. * Update docs/tools.md Co-authored-by: Peter Savchenko <[email protected]> * Update example/example-dev.html Co-authored-by: Peter Savchenko <[email protected]> * Update example/example.html Co-authored-by: Peter Savchenko <[email protected]> * Update example/example-dev.html Co-authored-by: Peter Savchenko <[email protected]> * Update example/example.html Co-authored-by: Peter Savchenko <[email protected]> * Update src/components/utils.ts Co-authored-by: Peter Savchenko <[email protected]> * Update src/components/utils.ts Co-authored-by: Peter Savchenko <[email protected]> * Update types/configs/editor-config.d.ts Co-authored-by: Peter Savchenko <[email protected]> * Update types/configs/editor-config.d.ts Co-authored-by: Peter Savchenko <[email protected]> * Update src/components/utils.ts Co-authored-by: Peter Savchenko <[email protected]> * Fix needAddDefaultBlock to needToAddDefaultBlock * Add as an Improvement to CHANGELOG.md * Delete editor.js.map * fix log, rename some more places * Update example.html * Update blockManager.ts Co-authored-by: Peter Savchenko <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> Co-authored-by: tasuku-s <[email protected]> Co-authored-by: Athul Anil Kumar <[email protected]> Co-authored-by: Taly <[email protected]> Co-authored-by: flaming-cl <[email protected]> Co-authored-by: Nguyen Ngoc Son <[email protected]> Co-authored-by: Sisir Das K <[email protected]> Co-authored-by: Sisir <[email protected]> * Fix blocks.delete with undefined index (#1182) (#1218) * [Improvements] ESLint action (#1099) * TSLint -> ESLint, GitHub Action * Update eslint.yml * Autofix * more autofix * fix * manually fix some issues * Update CHANGELOG.md * [Refactor] ESLint fixed (#1100) Co-authored-by: Peter Savchenko <[email protected]> * [Feature] i18n (#1106) * i18n first steps * i18n internal, toolbox, api for tools * namespaced api * tn, t * tn in block tunes * join toolbox and inlineTools under toolNames * translations * make enum toolTypes * Update block.ts * Update src/components/core.ts Co-Authored-By: George Berezhnoy <[email protected]> * add more types * rm tn * export i18n types * upd bundle * fix tabulation * Add type-safe namespaces * upd * Improve example * Update toolbox.ts * improve examplle * upd * fix typo * Add comments for complex types Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> * Remove unused submodule * Fixed: icon centering in Firefox * Do not load styles twice (#1112) * Do not load styles twice * Add changelog * Fix issue link Co-authored-by: Peter Savchenko <[email protected]> * Show warning if Block to delete is not found (#1111) Resolves #1102 * Save Tools' order in the Toolbox (#1113) Resolves #1073 * fix $.isEmpty performance (#1096) * fix $.isEmpty performance * add changelog * upd bundle Co-authored-by: Peter Savchenko <[email protected]> * Add issue templates (#1114) * Update issue templates (#1121) * Update issue templates * Apply suggestions from code review Co-Authored-By: George Berezhnoy <[email protected]> * upd texts * Update feature_request.md * Update .github/ISSUE_TEMPLATE/discussion.md Co-Authored-By: George Berezhnoy <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * Allowing deleting block by block id (#1108) * Allowing deleting block by block id * Fixed no argument error * Making index value optional for delete operation * Added to changelog * Making index value optional for delete operation * Added parameter description * Update docs/CHANGELOG.md * Update types/api/blocks.d.ts * Update editor.js Co-authored-by: Peter Savchenko <[email protected]> * Allow navigate next from last non-initial block (#1110) Resolves #1103 * Create CODE_OF_CONDUCT.md (#1171) * Create CODE_OF_CONDUCT.md * Update changelog file * Update dependencies (#1122) * Update dependencies * upd codex.tooltip * Update editor.js.LICENSE.txt Co-authored-by: Peter Savchenko <[email protected]> * Feature/disable tab event config (#1164) * Highlight first block on autofocus (#1127) * Fix shortcut for external tools (#1141) * fix/shortcut-for-external-tools * Check inline tools property for shortcut Co-authored-by: George Berezhnoy <[email protected]> * Hotfix/issue1133 selection shortcut removed on editor destroy (#1140) * Removed shortcut CMD+A on editor destroy #1133 * Removed patch version and made code cleaner #1133 * lint error fixes #1133 Co-authored-by: Sisir <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * [Feature] BlockAPI Interface (#1075) * Fix BlockManager.insert method (#1172) * Fix BlockManager.insert method * upd * Explicitly check for undefined * Update tools master branches (#1180) * Update master branches * Update image * Update CHANGELOG.md * Fix behaviour of inputs editing in block settings (#1123) * lint code * Update CHANGELOG.md * fix: blocks.delete with undefined index (#1182) * Add as a Fix in CHANGELOG.md. * Update editor.js Co-authored-by: Peter Savchenko <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> Co-authored-by: tasuku-s <[email protected]> Co-authored-by: Athul Anil Kumar <[email protected]> Co-authored-by: Taly <[email protected]> Co-authored-by: flaming-cl <[email protected]> Co-authored-by: Nguyen Ngoc Son <[email protected]> Co-authored-by: Sisir Das K <[email protected]> Co-authored-by: Sisir <[email protected]> Co-authored-by: ranemihir <[email protected]> * Fix spam clicking the tune button in Firefox (#1285) * Fix spam cliclikng tune in Firefox #1273 * build * Disabled unwanted I18n messages (#1282) * The unwanted I18n messages from console is disabled * Update docs/CHANGELOG.md Improved Change log Co-authored-by: Peter Savchenko <[email protected]> * Remove import statement import * as _ from '../utils'; removed * Apply suggestions from code review Co-authored-by: Peter Savchenko <[email protected]> Co-authored-by: Peter Savchenko <[email protected]> * Move SavedData and ValidatedData interfaces from internal types (#1251) * Move SavedData and ValidatedData interfaces from internal types * Add changelog * Upd submodules (#1287) * upd modules * Revert "upd modules" This reverts commit e2ff850d9de991bb61357e1955aed3e4318f4e55. * upd modules * Tools destroy called when the editor is destroyed (#1264) * Tools destroy called when the editor is destroyed When the editor instance is destroyed, it calls the destroy of the blockManager. blockManager inturn calls destroy of all the blocks that it manages. * Fixed lint errors * Use Prmoise.all and add as a Fix in CHANGELOG.md * Fix commit * Fix CHANGELOG.md * Add call of Tools reset methods * Update tools * Update changelog * Update docs/CHANGELOG.md Co-authored-by: Peter Savchenko <[email protected]> * upd all * bundle * upd tools Co-authored-by: ranemihir <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Peter Savchenko <[email protected]> * Bump elliptic from 6.5.2 to 6.5.3 (#1257) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](https://github.com/indutny/elliptic/compare/v6.5.2...v6.5.3) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix for input and textarea bug (#1214) * [Improvements] ESLint action (#1099) * TSLint -> ESLint, GitHub Action * Update eslint.yml * Autofix * more autofix * fix * manually fix some issues * Update CHANGELOG.md * [Refactor] ESLint fixed (#1100) Co-authored-by: Peter Savchenko <[email protected]> * [Feature] i18n (#1106) * i18n first steps * i18n internal, toolbox, api for tools * namespaced api * tn, t * tn in block tunes * join toolbox and inlineTools under toolNames * translations * make enum toolTypes * Update block.ts * Update src/components/core.ts Co-Authored-By: George Berezhnoy <[email protected]> * add more types * rm tn * export i18n types * upd bundle * fix tabulation * Add type-safe namespaces * upd * Improve example * Update toolbox.ts * improve examplle * upd * fix typo * Add comments for complex types Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> * Remove unused submodule * Fixed: icon centering in Firefox * Do not load styles twice (#1112) * Do not load styles twice * Add changelog * Fix issue link Co-authored-by: Peter Savchenko <[email protected]> * Show warning if Block to delete is not found (#1111) Resolves #1102 * Save Tools' order in the Toolbox (#1113) Resolves #1073 * fix $.isEmpty performance (#1096) * fix $.isEmpty performance * add changelog * upd bundle Co-authored-by: Peter Savchenko <[email protected]> * Add issue templates (#1114) * Update issue templates (#1121) * Update issue templates * Apply suggestions from code review Co-Authored-By: George Berezhnoy <[email protected]> * upd texts * Update feature_request.md * Update .github/ISSUE_TEMPLATE/discussion.md Co-Authored-By: George Berezhnoy <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * Allowing deleting block by block id (#1108) * Allowing deleting block by block id * Fixed no argument error * Making index value optional for delete operation * Added to changelog * Making index value optional for delete operation * Added parameter description * Update docs/CHANGELOG.md * Update types/api/blocks.d.ts * Update editor.js Co-authored-by: Peter Savchenko <[email protected]> * Allow navigate next from last non-initial block (#1110) Resolves #1103 * Create CODE_OF_CONDUCT.md (#1171) * Create CODE_OF_CONDUCT.md * Update changelog file * Update dependencies (#1122) * Update dependencies * upd codex.tooltip * Update editor.js.LICENSE.txt Co-authored-by: Peter Savchenko <[email protected]> * Feature/disable tab event config (#1164) * Highlight first block on autofocus (#1127) * Fix shortcut for external tools (#1141) * fix/shortcut-for-external-tools * Check inline tools property for shortcut Co-authored-by: George Berezhnoy <[email protected]> * Hotfix/issue1133 selection shortcut removed on editor destroy (#1140) * Removed shortcut CMD+A on editor destroy #1133 * Removed patch version and made code cleaner #1133 * lint error fixes #1133 Co-authored-by: Sisir <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * [Feature] BlockAPI Interface (#1075) * Fix BlockManager.insert method (#1172) * Fix BlockManager.insert method * upd * Explicitly check for undefined * Update tools master branches (#1180) * Update master branches * Update image * Update CHANGELOG.md * Fix behaviour of inputs editing in block settings (#1123) * lint code * Update CHANGELOG.md * added handling of inputs and textareas in custom plugins * Upd tools * Add changelog * Upd submodules Co-authored-by: Peter Savchenko <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> Co-authored-by: tasuku-s <[email protected]> Co-authored-by: Athul Anil Kumar <[email protected]> Co-authored-by: Taly <[email protected]> Co-authored-by: flaming-cl <[email protected]> Co-authored-by: Nguyen Ngoc Son <[email protected]> Co-authored-by: Sisir Das K <[email protected]> Co-authored-by: Sisir <[email protected]> * Typos changes required to be fixed on website when using the import concept (#1260) * Typos changes. Required to fix them too on the official documentation website * Update README.md Co-authored-by: George Berezhnoy <[email protected]> * Use only import Co-authored-by: Peter Savchenko <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * Add hidden option to toolbox (#1220) * Add hidden option to toolbox * Use false in order to hide toolbox * Add comment what false means * Add issue #1221 to changelog Co-authored-by: t.hata <[email protected]> * Add RTL support (#1248) * [Improvements] ESLint action (#1099) * TSLint -> ESLint, GitHub Action * Update eslint.yml * Autofix * more autofix * fix * manually fix some issues * Update CHANGELOG.md * [Refactor] ESLint fixed (#1100) Co-authored-by: Peter Savchenko <[email protected]> * [Feature] i18n (#1106) * i18n first steps * i18n internal, toolbox, api for tools * namespaced api * tn, t * tn in block tunes * join toolbox and inlineTools under toolNames * translations * make enum toolTypes * Update block.ts * Update src/components/core.ts Co-Authored-By: George Berezhnoy <[email protected]> * add more types * rm tn * export i18n types * upd bundle * fix tabulation * Add type-safe namespaces * upd * Improve example * Update toolbox.ts * improve examplle * upd * fix typo * Add comments for complex types Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> * Remove unused submodule * Fixed: icon centering in Firefox * Do not load styles twice (#1112) * Do not load styles twice * Add changelog * Fix issue link Co-authored-by: Peter Savchenko <[email protected]> * Show warning if Block to delete is not found (#1111) Resolves #1102 * Save Tools' order in the Toolbox (#1113) Resolves #1073 * fix $.isEmpty performance (#1096) * fix $.isEmpty performance * add changelog * upd bundle Co-authored-by: Peter Savchenko <[email protected]> * Add issue templates (#1114) * Update issue templates (#1121) * Update issue templates * Apply suggestions from code review Co-Authored-By: George Berezhnoy <[email protected]> * upd texts * Update feature_request.md * Update .github/ISSUE_TEMPLATE/discussion.md Co-Authored-By: George Berezhnoy <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * Allowing deleting block by block id (#1108) * Allowing deleting block by block id * Fixed no argument error * Making index value optional for delete operation * Added to changelog * Making index value optional for delete operation * Added parameter description * Update docs/CHANGELOG.md * Update types/api/blocks.d.ts * Update editor.js Co-authored-by: Peter Savchenko <[email protected]> * Allow navigate next from last non-initial block (#1110) Resolves #1103 * Create CODE_OF_CONDUCT.md (#1171) * Create CODE_OF_CONDUCT.md * Update changelog file * Update dependencies (#1122) * Update dependencies * upd codex.tooltip * Update editor.js.LICENSE.txt Co-authored-by: Peter Savchenko <[email protected]> * Feature/disable tab event config (#1164) * Highlight first block on autofocus (#1127) * Fix shortcut for external tools (#1141) * fix/shortcut-for-external-tools * Check inline tools property for shortcut Co-authored-by: George Berezhnoy <[email protected]> * Hotfix/issue1133 selection shortcut removed on editor destroy (#1140) * Removed shortcut CMD+A on editor destroy #1133 * Removed patch version and made code cleaner #1133 * lint error fixes #1133 Co-authored-by: Sisir <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * [Feature] BlockAPI Interface (#1075) * Fix BlockManager.insert method (#1172) * Fix BlockManager.insert method * upd * Explicitly check for undefined * Update tools master branches (#1180) * Update master branches * Update image * Update CHANGELOG.md * Fix behaviour of inputs editing in block settings (#1123) * lint code * Update CHANGELOG.md * Added RTL support * Fixed code style * Fixed icons positioning in the toolbar in the RTL mode * Renamed example-dev-rtl.html to example-rtl.html * Moved 'direction' option to 'i18n' section * Fixed an issue with arrow navigation between blocks * Renamed rtl-fix to codex-editor--rtl * Fixed icons positioning in the narrow mode for RTL * Replaced 'isRtl' method with getter * Fixed bug with the editor initialization when 'i18n' option is not set * narrow mode improved * Changelog added Co-authored-by: Peter Savchenko <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> Co-authored-by: tasuku-s <[email protected]> Co-authored-by: Athul Anil Kumar <[email protected]> Co-authored-by: Taly <[email protected]> Co-authored-by: flaming-cl <[email protected]> Co-authored-by: Nguyen Ngoc Son <[email protected]> Co-authored-by: Sisir Das K <[email protected]> Co-authored-by: Sisir <[email protected]> Co-authored-by: ImangazalievM <[email protected]> * Fix i18n default configuration (#1290) * Fix i18n default configuration * update bundle * Fixing Bug #1270 and resolve all yarn lint warning. (#1292) * Fixing Bug #1270 and resolve all yarn lint warning. * Update CHANGELOG.md * Change the Log type from Error to Warn * upd types Co-authored-by: Peter Savchenko <[email protected]> * Stop click propagation only if click cause action (#1252) * Fixing: #843 problem with onchange callback (#1310) * Fixing: #843 problem with onchange callback * Update docs/CHANGELOG.md Co-authored-by: Peter Savchenko <[email protected]> Co-authored-by: Peter Savchenko <[email protected]> * The read-only mode (#1035) (ﾉ◕ヮ◕)ﾉ*:･ﾟ✧ * Update submodules (#1335) * Add inlineToolbar property (#1293) * Add inlineToolbar property * Fix lint errors * Fix comments Co-authored-by: Murod Khaydarov <[email protected]> * Sort Tools Working, Can be optimized further * Fix dataset error and use children * Fix lint errors * Add as improvement to CHNAGELOG.md * Fix comments Co-authored-by: Peter Savchenko <[email protected]> * Add comments and small fixes * Fix lint errors * Fix sortTools() and check inlineToolbar property * Fix lint errors * Fix conditions and property names * Separate block toggler from buttons list in ui * Fix lint errors * Fix condition names in allowedToShow() * Minor bug fixes * Fix linter warnings * Update docs/CHANGELOG.md Co-authored-by: Murod Khaydarov <[email protected]> * create inlineToolbarSettings() method * Minor fixes * Clearify boolean casting * upd bundle * fix getInlineToolbarSettings * refactor & create new instance every showing * remove unused codee Co-authored-by: Murod Khaydarov <[email protected]> Co-authored-by: Peter Savchenko <[email protected]> * Throw error only if read-only is enabled from the start (#1337) * Throw error only if read-only is enabled from the start * update modules * Fixed the 1302 bug and improve the tab key behaviour (#1342) * Fixed the 1302 bug and improve the tab key behaviour * yarn lint:fixed based improvements * Update docs/CHANGELOG.md Co-authored-by: Peter Savchenko <[email protected]> * Update src/components/modules/ui.ts Co-authored-by: Peter Savchenko <[email protected]> Co-authored-by: Peter Savchenko <[email protected]> * Fix caret behaviour (#1343) * Fix caret behaviour * Fix current input update * Toggle readonly on start (#1344) * Toggle readonly on start * Do not render block twice on start * Bugfix/fix modification observer disable (#1340) * Enable modification observer when onChange callback throws an error * Build * Update src/components/modules/modificationsObserver.ts Co-authored-by: George Berezhnoy <[email protected]> * Update CHANGELOG Co-authored-by: t.hata <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * Improve the changelog and read-only toggler (#1347) * Use activeElement if anchorNode is undefined (#1350) * FIx errors on enter press when several blocks selected (#1349) * FIx errors on enter press when several blocks selected * Fix for safari * Fix blocks copy in read-only (#1351) Co-authored-by: Qays <[email protected]> Co-authored-by: Jacob Smith <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> Co-authored-by: tasuku-s <[email protected]> Co-authored-by: Athul Anil Kumar <[email protected]> Co-authored-by: Taly <[email protected]> Co-authored-by: flaming-cl <[email protected]> Co-authored-by: Nguyen Ngoc Son <[email protected]> Co-authored-by: Sisir Das K <[email protected]> Co-authored-by: Sisir <[email protected]> Co-authored-by: ranemihir <[email protected]> Co-authored-by: Mihir Rane <[email protected]> Co-authored-by: Stephen Richard <[email protected]> Co-authored-by: Umang G. Patel <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nikola Pavlovic <[email protected]> Co-authored-by: Cyber_Ninja <[email protected]> Co-authored-by: Tomoyuki Hata <[email protected]> Co-authored-by: t.hata <[email protected]> Co-authored-by: Mahach Imangazaliev <[email protected]> Co-authored-by: ImangazalievM <[email protected]> Co-authored-by: Murod Khaydarov <[email protected]> Co-authored-by: Hugh Boylan <[email protected]> Co-authored-by: Murod Khaydarov <[email protected]> * Revert "Release: 2.19 (#1341)" (#1363) This reverts commit 78775703c967dee84d75689135333b5d89db392b. * Release: 2.19 (#1364) * typo fixed (#1235) * Improvements: more translations added to the i18n example (#1250) * Return the result of block.call (#1205) * [Improvements] ESLint action (#1099) * TSLint -> ESLint, GitHub Action * Update eslint.yml * Autofix * more autofix * fix * manually fix some issues * Update CHANGELOG.md * [Refactor] ESLint fixed (#1100) Co-authored-by: Peter Savchenko <[email protected]> * [Feature] i18n (#1106) * i18n first steps * i18n internal, toolbox, api for tools * namespaced api * tn, t * tn in block tunes * join toolbox and inlineTools under toolNames * translations * make enum toolTypes * Update block.ts * Update src/components/core.ts Co-Authored-By: George Berezhnoy <[email protected]> * add more types * rm tn * export i18n types * upd bundle * fix tabulation * Add type-safe namespaces * upd * Improve example * Update toolbox.ts * improve examplle * upd * fix typo * Add comments for complex types Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> * Remove unused submodule * Fixed: icon centering in Firefox * Do not load styles twice (#1112) * Do not load styles twice * Add changelog * Fix issue link Co-authored-by: Peter Savchenko <[email protected]> * Show warning if Block to delete is not found (#1111) Resolves #1102 * Save Tools' order in the Toolbox (#1113) Resolves #1073 * fix $.isEmpty performance (#1096) * fix $.isEmpty performance * add changelog * upd bundle Co-authored-by: Peter Savchenko <[email protected]> * Add issue templates (#1114) * Update issue templates (#1121) * Update issue templates * Apply suggestions from code review Co-Authored-By: George Berezhnoy <[email protected]> * upd texts * Update feature_request.md * Update .github/ISSUE_TEMPLATE/discussion.md Co-Authored-By: George Berezhnoy <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * Allowing deleting block by block id (#1108) * Allowing deleting block by block id * Fixed no argument error * Making index value optional for delete operation * Added to changelog * Making index value optional for delete operation * Added parameter description * Update docs/CHANGELOG.md * Update types/api/blocks.d.ts * Update editor.js Co-authored-by: Peter Savchenko <[email protected]> * Allow navigate next from last non-initial block (#1110) Resolves #1103 * Create CODE_OF_CONDUCT.md (#1171) * Create CODE_OF_CONDUCT.md * Update changelog file * Update dependencies (#1122) * Update dependencies * upd codex.tooltip * Update editor.js.LICENSE.txt Co-authored-by: Peter Savchenko <[email protected]> * Feature/disable tab event config (#1164) * Highlight first block on autofocus (#1127) * Fix shortcut for external tools (#1141) * fix/shortcut-for-external-tools * Check inline tools property for shortcut Co-authored-by: George Berezhnoy <[email protected]> * Hotfix/issue1133 selection shortcut removed on editor destroy (#1140) * Removed shortcut CMD+A on editor destroy #1133 * Removed patch version and made code cleaner #1133 * lint error fixes #1133 Co-authored-by: Sisir <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * [Feature] BlockAPI Interface (#1075) * Fix BlockManager.insert method (#1172) * Fix BlockManager.insert method * upd * Explicitly check for undefined * Update tools master branches (#1180) * Update master branches * Update image * Update CHANGELOG.md * Fix behaviour of inputs editing in block settings (#1123) * lint code * Update CHANGELOG.md * Return the result of block.call This change allows blocks to return the result of `call` methods, thus allowing them to expose arbitrary data as needed. My particular use case is I am using Vue to mount components inside of the larger editorjs framework. One of the components that we are developing can be thought of as a nested agenda, where labels need to be in an order like: ``` I. Top level a. second level i. third level ``` My plan is to have an orchestrator query all blocks, filter those that need labels prepended, and then programmatically tell each block (with another `call` method) to set its depth to the desired level. At that point, Vue can reactively update any labels, etc. that are needed. I believe this change will allow for other such uses, and I imagine it should not break any existing code since it was returning `null` before. * Disable ESLint for call method return value Because we are returning the value of an arbitrary function, the return value can be anything (hence, the return type must be `any`). However, to reduce noise in ESLint output, we disable ESLint checking the line with the `any` type return. * Change any type to unknown and add to CHANGELOG.md Change any type of the call method to unknown but eslint shows error saying the unknown type is undefined, Also, add the chnage to CHANGELOG.md as an improvement with the link to the PR itself as no issue was assigned with it. * Add unknown to eslint globals * upd Co-authored-by: Peter Savchenko <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> Co-authored-by: tasuku-s <[email protected]> Co-authored-by: Athul Anil Kumar <[email protected]> Co-authored-by: Taly <[email protected]> Co-authored-by: flaming-cl <[email protected]> Co-authored-by: Nguyen Ngoc Son <[email protected]> Co-authored-by: Sisir Das K <[email protected]> Co-authored-by: Sisir <[email protected]> Co-authored-by: ranemihir <[email protected]> * <fix> toolbar--opened overlap with certain text [issue 1196] (#1201) * [Improvements] ESLint action (#1099) * TSLint -> ESLint, GitHub Action * Update eslint.yml * Autofix * more autofix * fix * manually fix some issues * Update CHANGELOG.md * [Refactor] ESLint fixed (#1100) Co-authored-by: Peter Savchenko <[email protected]> * [Feature] i18n (#1106) * i18n first steps * i18n internal, toolbox, api for tools * namespaced api * tn, t * tn in block tunes * join toolbox and inlineTools under toolNames * translations * make enum toolTypes * Update block.ts * Update src/components/core.ts Co-Authored-By: George Berezhnoy <[email protected]> * add more types * rm tn * export i18n types * upd bundle * fix tabulation * Add type-safe namespaces * upd * Improve example * Update toolbox.ts * improve examplle * upd * fix typo * Add comments for complex types Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> * Remove unused submodule * Fixed: icon centering in Firefox * Do not load styles twice (#1112) * Do not load styles twice * Add changelog * Fix issue link Co-authored-by: Peter Savchenko <[email protected]> * Show warning if Block to delete is not found (#1111) Resolves #1102 * Save Tools' order in the Toolbox (#1113) Resolves #1073 * fix $.isEmpty performance (#1096) * fix $.isEmpty performance * add changelog * upd bundle Co-authored-by: Peter Savchenko <[email protected]> * Add issue templates (#1114) * Update issue templates (#1121) * Update issue templates * Apply suggestions from code review Co-Authored-By: George Berezhnoy <[email protected]> * upd texts * Update feature_request.md * Update .github/ISSUE_TEMPLATE/discussion.md Co-Authored-By: George Berezhnoy <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * Allowing deleting block by block id (#1108) * Allowing deleting block by block id * Fixed no argument error * Making index value optional for delete operation * Added to changelog * Making index value optional for delete operation * Added parameter description * Update docs/CHANGELOG.md * Update types/api/blocks.d.ts * Update editor.js Co-authored-by: Peter Savchenko <[email protected]> * Allow navigate next from last non-initial block (#1110) Resolves #1103 * Create CODE_OF_CONDUCT.md (#1171) * Create CODE_OF_CONDUCT.md * Update changelog file * Update dependencies (#1122) * Update dependencies * upd codex.tooltip * Update editor.js.LICENSE.txt Co-authored-by: Peter Savchenko <[email protected]> * Feature/disable tab event config (#1164) * Highlight first block on autofocus (#1127) * Fix shortcut for external tools (#1141) * fix/shortcut-for-external-tools * Check inline tools property for shortcut Co-authored-by: George Berezhnoy <[email protected]> * Hotfix/issue1133 selection shortcut removed on editor destroy (#1140) * Removed shortcut CMD+A on editor destroy #1133 * Removed patch version and made code cleaner #1133 * lint error fixes #1133 Co-authored-by: Sisir <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * [Feature] BlockAPI Interface (#1075) * Fix BlockManager.insert method (#1172) * Fix BlockManager.insert method * upd * Explicitly check for undefined * Update tools master branches (#1180) * Update master branches * Update image * Update CHANGELOG.md * Fix behaviour of inputs editing in block settings (#1123) * lint code * Update CHANGELOG.md * <fix> toolbar overlap with text * Add Fix in CHANGELOG.md * Update editor.js Co-authored-by: Peter Savchenko <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> Co-authored-by: tasuku-s <[email protected]> Co-authored-by: Athul Anil Kumar <[email protected]> Co-authored-by: Taly <[email protected]> Co-authored-by: Nguyen Ngoc Son <[email protected]> Co-authored-by: Sisir Das K <[email protected]> Co-authored-by: Sisir <[email protected]> Co-authored-by: ranemihir <[email protected]> * Rename initialBlock to defaultBlock (#1209) * [Improvements] ESLint action (#1099) * TSLint -> ESLint, GitHub Action * Update eslint.yml * Autofix * more autofix * fix * manually fix some issues * Update CHANGELOG.md * [Refactor] ESLint fixed (#1100) Co-authored-by: Peter Savchenko <[email protected]> * [Feature] i18n (#1106) * i18n first steps * i18n internal, toolbox, api for tools * namespaced api * tn, t * tn in block tunes * join toolbox and inlineTools under toolNames * translations * make enum toolTypes * Update block.ts * Update src/components/core.ts Co-Authored-By: George Berezhnoy <[email protected]> * add more types * rm tn * export i18n types * upd bundle * fix tabulation * Add type-safe namespaces * upd * Improve example * Update toolbox.ts * improve examplle * upd * fix typo * Add comments for complex types Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> * Remove unused submodule * Fixed: icon centering in Firefox * Do not load styles twice (#1112) * Do not load styles twice * Add changelog * Fix issue link Co-authored-by: Peter Savchenko <[email protected]> * Show warning if Block to delete is not found (#1111) Resolves #1102 * Save Tools' order in the Toolbox (#1113) Resolves #1073 * fix $.isEmpty performance (#1096) * fix $.isEmpty performance * add changelog * upd bundle Co-authored-by: Peter Savchenko <[email protected]> * Add issue templates (#1114) * Update issue templates (#1121) * Update issue templates * Apply suggestions from code review Co-Authored-By: George Berezhnoy <[email protected]> * upd texts * Update feature_request.md * Update .github/ISSUE_TEMPLATE/discussion.md Co-Authored-By: George Berezhnoy <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * Allowing deleting block by block id (#1108) * Allowing deleting block by block id * Fixed no argument error * Making index value optional for delete operation * Added to changelog * Making index value optional for delete operation * Added parameter description * Update docs/CHANGELOG.md * Update types/api/blocks.d.ts * Update editor.js Co-authored-by: Peter Savchenko <[email protected]> * Allow navigate next from last non-initial block (#1110) Resolves #1103 * Create CODE_OF_CONDUCT.md (#1171) * Create CODE_OF_CONDUCT.md * Update changelog file * Update dependencies (#1122) * Update dependencies * upd codex.tooltip * Update editor.js.LICENSE.txt Co-authored-by: Peter Savchenko <[email protected]> * Feature/disable tab event config (#1164) * Highlight first block on autofocus (#1127) * Fix shortcut for external tools (#1141) * fix/shortcut-for-external-tools * Check inline tools property for shortcut Co-authored-by: George Berezhnoy <[email protected]> * Hotfix/issue1133 selection shortcut removed on editor destroy (#1140) * Removed shortcut CMD+A on editor destroy #1133 * Removed patch version and made code cleaner #1133 * lint error fixes #1133 Co-authored-by: Sisir <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * [Feature] BlockAPI Interface (#1075) * Fix BlockManager.insert method (#1172) * Fix BlockManager.insert method * upd * Explicitly check for undefined * Update tools master branches (#1180) * Update master branches * Update image * Update CHANGELOG.md * Fix behaviour of inputs editing in block settings (#1123) * lint code * Update CHANGELOG.md * Rename initialBlock to defaultBlock Closes #993 The initialBlock property is renamed to defaultBlock. * Change keyword 'InitialBlock' to 'DefaultBlock' in all methods Fixes #993 All the methods using the keyword 'Initial' or 'initial' for initial block are replace with 'Default' or 'default'. For example, the Tools.isIntitial() method is changed to Tools.isDefault(). * Keep initialBlock and defaultBlock both. initialBlock property is still kept but it will deprecated in the next major release. * Change defaultBlock in example.html and rebuild. * Remove package-lock.json file. * Update docs/tools.md Co-authored-by: Peter Savchenko <[email protected]> * Update example/example-dev.html Co-authored-by: Peter Savchenko <[email protected]> * Update example/example.html Co-authored-by: Peter Savchenko <[email protected]> * Update example/example-dev.html Co-authored-by: Peter Savchenko <[email protected]> * Update example/example.html Co-authored-by: Peter Savchenko <[email protected]> * Update src/components/utils.ts Co-authored-by: Peter Savchenko <[email protected]> * Update src/components/utils.ts Co-authored-by: Peter Savchenko <[email protected]> * Update types/configs/editor-config.d.ts Co-authored-by: Peter Savchenko <[email protected]> * Update types/configs/editor-config.d.ts Co-authored-by: Peter Savchenko <[email protected]> * Update src/components/utils.ts Co-authored-by: Peter Savchenko <[email protected]> * Fix needAddDefaultBlock to needToAddDefaultBlock * Add as an Improvement to CHANGELOG.md * Delete editor.js.map * fix log, rename some more places * Update example.html * Update blockManager.ts Co-authored-by: Peter Savchenko <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> Co-authored-by: tasuku-s <[email protected]> Co-authored-by: Athul Anil Kumar <[email protected]> Co-authored-by: Taly <[email protected]> Co-authored-by: flaming-cl <[email protected]> Co-authored-by: Nguyen Ngoc Son <[email protected]> Co-authored-by: Sisir Das K <[email protected]> Co-authored-by: Sisir <[email protected]> * Fix blocks.delete with undefined index (#1182) (#1218) * [Improvements] ESLint action (#1099) * TSLint -> ESLint, GitHub Action * Update eslint.yml * Autofix * more autofix * fix * manually fix some issues * Update CHANGELOG.md * [Refactor] ESLint fixed (#1100) Co-authored-by: Peter Savchenko <[email protected]> * [Feature] i18n (#1106) * i18n first steps * i18n internal, toolbox, api for tools * namespaced api * tn, t * tn in block tunes * join toolbox and inlineTools under toolNames * translations * make enum toolTypes * Update block.ts * Update src/components/core.ts Co-Authored-By: George Berezhnoy <[email protected]> * add more types * rm tn * export i18n types * upd bundle * fix tabulation * Add type-safe namespaces * upd * Improve example * Update toolbox.ts * improve examplle * upd * fix typo * Add comments for complex types Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> * Remove unused submodule * Fixed: icon centering in Firefox * Do not load styles twice (#1112) * Do not load styles twice * Add changelog * Fix issue link Co-authored-by: Peter Savchenko <[email protected]> * Show warning if Block to delete is not found (#1111) Resolves #1102 * Save Tools' order in the Toolbox (#1113) Resolves #1073 * fix $.isEmpty performance (#1096) * fix $.isEmpty performance * add changelog * upd bundle Co-authored-by: Peter Savchenko <[email protected]> * Add issue templates (#1114) * Update issue templates (#1121) * Update issue templates * Apply suggestions from code review Co-Authored-By: George Berezhnoy <[email protected]> * upd texts * Update feature_request.md * Update .github/ISSUE_TEMPLATE/discussion.md Co-Authored-By: George Berezhnoy <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * Allowing deleting block by block id (#1108) * Allowing deleting block by block id * Fixed no argument error * Making index value optional for delete operation * Added to changelog * Making index value optional for delete operation * Added parameter description * Update docs/CHANGELOG.md * Update types/api/blocks.d.ts * Update editor.js Co-authored-by: Peter Savchenko <[email protected]> * Allow navigate next from last non-initial block (#1110) Resolves #1103 * Create CODE_OF_CONDUCT.md (#1171) * Create CODE_OF_CONDUCT.md * Update changelog file * Update dependencies (#1122) * Update dependencies * upd codex.tooltip * Update editor.js.LICENSE.txt Co-authored-by: Peter Savchenko <[email protected]> * Feature/disable tab event config (#1164) * Highlight first block on autofocus (#1127) * Fix shortcut for external tools (#1141) * fix/shortcut-for-external-tools * Check inline tools property for shortcut Co-authored-by: George Berezhnoy <[email protected]> * Hotfix/issue1133 selection shortcut removed on editor destroy (#1140) * Removed shortcut CMD+A on editor destroy #1133 * Removed patch version and made code cleaner #1133 * lint error fixes #1133 Co-authored-by: Sisir <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * [Feature] BlockAPI Interface (#1075) * Fix BlockManager.insert method (#1172) * Fix BlockManager.insert method * upd * Explicitly check for undefined * Update tools master branches (#1180) * Update master branches * Update image * Update CHANGELOG.md * Fix behaviour of inputs editing in block settings (#1123) * lint code * Update CHANGELOG.md * fix: blocks.delete with undefined index (#1182) * Add as a Fix in CHANGELOG.md. * Update editor.js Co-authored-by: Peter Savchenko <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> Co-authored-by: tasuku-s <[email protected]> Co-authored-by: Athul Anil Kumar <[email protected]> Co-authored-by: Taly <[email protected]> Co-authored-by: flaming-cl <[email protected]> Co-authored-by: Nguyen Ngoc Son <[email protected]> Co-authored-by: Sisir Das K <[email protected]> Co-authored-by: Sisir <[email protected]> Co-authored-by: ranemihir <[email protected]> * Fix spam clicking the tune button in Firefox (#1285) * Fix spam cliclikng tune in Firefox #1273 * build * Disabled unwanted I18n messages (#1282) * The unwanted I18n messages from console is disabled * Update docs/CHANGELOG.md Improved Change log Co-authored-by: Peter Savchenko <[email protected]> * Remove import statement import * as _ from '../utils'; removed * Apply suggestions from code review Co-authored-by: Peter Savchenko <[email protected]> Co-authored-by: Peter Savchenko <[email protected]> * Move SavedData and ValidatedData interfaces from internal types (#1251) * Move SavedData and ValidatedData interfaces from internal types * Add changelog * Upd submodules (#1287) * upd modules * Revert "upd modules" This reverts commit e2ff850d9de991bb61357e1955aed3e4318f4e55. * upd modules * Tools destroy called when the editor is destroyed (#1264) * Tools destroy called when the editor is destroyed When the editor instance is destroyed, it calls the destroy of the blockManager. blockManager inturn calls destroy of all the blocks that it manages. * Fixed lint errors * Use Prmoise.all and add as a Fix in CHANGELOG.md * Fix commit * Fix CHANGELOG.md * Add call of Tools reset methods * Update tools * Update changelog * Update docs/CHANGELOG.md Co-authored-by: Peter Savchenko <[email protected]> * upd all * bundle * upd tools Co-authored-by: ranemihir <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Peter Savchenko <[email protected]> * Bump elliptic from 6.5.2 to 6.5.3 (#1257) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](https://github.com/indutny/elliptic/compare/v6.5.2...v6.5.3) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix for input and textarea bug (#1214) * [Improvements] ESLint action (#1099) * TSLint -> ESLint, GitHub Action * Update eslint.yml * Autofix * more autofix * fix * manually fix some issues * Update CHANGELOG.md * [Refactor] ESLint fixed (#1100) Co-authored-by: Peter Savchenko <[email protected]> * [Feature] i18n (#1106) * i18n first steps * i18n internal, toolbox, api for tools * namespaced api * tn, t * tn in block tunes * join toolbox and inlineTools under toolNames * translations * make enum toolTypes * Update block.ts * Update src/components/core.ts Co-Authored-By: George Berezhnoy <[email protected]> * add more types * rm tn * export i18n types * upd bundle * fix tabulation * Add type-safe namespaces * upd * Improve example * Update toolbox.ts * improve examplle * upd * fix typo * Add comments for complex types Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Georgy Berezhnoy <[email protected]> * Remove unused submodule * Fixed: icon centering in Firefox * Do not load styles twice (#1112) * Do not load styles twice * Add changelog * Fix issue link Co-authored-by: Peter Savchenko <[email protected]> * Show warning if Block to delete is not found (#1111) Resolves #1102 * Save Tools' order in the Toolbox (#1113) Resolves #1073 * fix $.isEmpty performance (#1096) * fix $.isEmpty performance * add changelog * upd bundle Co-authored-by: Peter Savchenko <[email protected]> * Add issue templates (#1114) * Update issue templates (#1121) * Update issue templates * Apply suggestions from code review Co-Authored-By: George Berezhnoy <[email protected]> * upd texts * Update feature_request.md * Update .github/ISSUE_TEMPLATE/discussion.md Co-Authored-By: George Berezhnoy <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> * Allowing deleting block by block id (#1108) * Allowing deleting block by block id * Fixed no argument error * Making index value optional for delete operation * Added to changelog * Making index value optional for delete operation * Added parameter description * Update docs/CHANGELOG.md * Update types/api/blocks.d.ts * Update editor.js Co-authored-by: Peter Savchenko <[email protected]> * Allow navigate next from last non-initial block (#1110) Resolves #1103 * Create CODE_OF_CONDUCT.md (#1171) * Create CODE_OF_CONDUCT.md * Update changelog file * Update dependencies (#1122) * Update dependencies * upd codex.tooltip * Update editor.js.LICENSE.txt Co-authored-by: Peter Savchenko <[email protected]> * Feature/disable tab event config (#1164) * Highlight first block on autofocus (#1127) * Fix shortcut for external tools (#1141) * fix/shortcut-for-external-tools * Check inline tools property for shortcut Co-authored-by: George Berezhnoy <[email protected]> * Hotfix/issue1133 selection shortcut removed on editor destroy (#1140) * Removed shortcut CMD+A on editor destroy #1133 * Removed patch version and made code cleaner #1133 * lint error fixes #1133 Co-authored-by: Sisir <sisir@…

qqqays and others added 24 commits July 26, 2020 19:02

typo fixed (#1235)

52d919c

Improvements: more translations added to the i18n example (#1250)

33be205

Fix spam clicking the tune button in Firefox (#1285)

86dd9b2

* Fix spam cliclikng tune in Firefox #1273 * build

Move SavedData and ValidatedData interfaces from internal types (#1251)

333a3d0

* Move SavedData and ValidatedData interfaces from internal types * Add changelog

Upd submodules (#1287)

c097a12

* upd modules * Revert "upd modules" This reverts commit e2ff850. * upd modules

Add hidden option to toolbox (#1220)

cdb48c4

* Add hidden option to toolbox * Use false in order to hide toolbox * Add comment what false means * Add issue #1221 to changelog Co-authored-by: t.hata <[email protected]>

Fix i18n default configuration (#1290)

0929abc

* Fix i18n default configuration * update bundle

Fixing Bug #1270 and resolve all yarn lint warning. (#1292)

274e1d1

* Fixing Bug #1270 and resolve all yarn lint warning. * Update CHANGELOG.md * Change the Log type from Error to Warn * upd types Co-authored-by: Peter Savchenko <[email protected]>

Stop click propagation only if click cause action (#1252)

c1f9dd6

Fixing: #843 problem with onchange callback (#1310)

83131d6

* Fixing: #843 problem with onchange callback * Update docs/CHANGELOG.md Co-authored-by: Peter Savchenko <[email protected]> Co-authored-by: Peter Savchenko <[email protected]>

The read-only mode (#1035)

8a5adef

(ﾉ◕ヮ◕)ﾉ*:･ﾟ✧

Update submodules (#1335)

fdd00e3

Throw error only if read-only is enabled from the start (#1337)

b836359

* Throw error only if read-only is enabled from the start * update modules

neSpecc requested review from gohabereg and khaydarov as code owners October 5, 2020 16:35

robonetphy and others added 4 commits October 5, 2020 20:24

Fix caret behaviour (#1343)

d5f23aa

* Fix caret behaviour * Fix current input update

Toggle readonly on start (#1344)

1245a53

* Toggle readonly on start * Do not render block twice on start

Improve the changelog and read-only toggler (#1347)

a030072

talyguryn approved these changes Oct 7, 2020

View reviewed changes

gohabereg added 3 commits October 7, 2020 21:32

Use activeElement if anchorNode is undefined (#1350)

962d75a

FIx errors on enter press when several blocks selected (#1349)

8c55fa6

* FIx errors on enter press when several blocks selected * Fix for safari

Fix blocks copy in read-only (#1351)

0037a91

neSpecc commented Oct 8, 2020

View reviewed changes

khaydarov approved these changes Oct 12, 2020

View reviewed changes

gohabereg merged commit 7877570 into master Oct 12, 2020

gohabereg added a commit that referenced this pull request Oct 12, 2020

Revert "Release: 2.19 (#1341)"

6898443

This reverts commit 7877570.

gohabereg mentioned this pull request Oct 12, 2020

Revert "Release: 2.19" #1363

Merged

gohabereg added a commit that referenced this pull request Oct 12, 2020

Revert "Release: 2.19 (#1341)" (#1363)

b223d63

This reverts commit 7877570.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release: 2.19 #1341

Release: 2.19 #1341

neSpecc commented Oct 5, 2020

neSpecc left a comment

neSpecc Oct 8, 2020

neSpecc Oct 8, 2020

neSpecc Oct 8, 2020

neSpecc Oct 8, 2020

neSpecc Oct 8, 2020

gohabereg Oct 9, 2020

neSpecc Oct 8, 2020

neSpecc Oct 8, 2020

neSpecc Oct 8, 2020

neSpecc Oct 8, 2020

neSpecc Oct 8, 2020

	Use this page for debugging purposes.
	Use this page for the debugging of RTL mode.

	<title>Editor.js 🤩🧦🤨 example</title>
	<title>Editor.js RTL example</title>

Release: 2.19 #1341

Release: 2.19 #1341

Conversation

neSpecc commented Oct 5, 2020

neSpecc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment