Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RTL support #909

Closed
wants to merge 4 commits into from
Closed

Add RTL support #909

wants to merge 4 commits into from

Conversation

gincher
Copy link

@gincher gincher commented Oct 4, 2019

Issue: #670

I have created example-dev-rtl.html with Hebrew in the editor to be able to test the RTL. To make the editor RTL, the user should add to the config {direction: 'rtl'}.

Tasks done:

  • Modify CSS to support RTL
  • Calculate distance from the right for the tooltip
  • Right and left keys will move the user between blocks correctly
  • Inline URL input field will remain LTR

@hoseinz3xs
Copy link

@neSpecc @khaydarov @gohabereg Could you please review this feature? I definitely wanna this one

@neSpecc
Copy link
Member

neSpecc commented Oct 15, 2019

@hoseinz3xs sure, we will review it soon.

@gincher
Copy link
Author

gincher commented Oct 20, 2019

  • Flipper now works correctly with the keyboard arrows when RTL
  • Conversion window now appears on the right side

Sorry for the mess, accidently I was working on the master branch, but it looks like there is no problem

@r6m
Copy link

r6m commented Mar 25, 2020

@neSpecc any updates on this feature?

@neSpecc
Copy link
Member

neSpecc commented Mar 25, 2020

@rezam90 we'll try to include it to the next release.

@kfirba
Copy link

kfirba commented Apr 7, 2020

@neSpecc Is there any ETA as of when will this be merged? This seems like the only missing piece so we can use the editor in production :)

@neSpecc
Copy link
Member

neSpecc commented Apr 7, 2020

@kfirba May — June

@kfirba
Copy link

kfirba commented Apr 7, 2020

@neSpecc oh wow, that was a snappy response. Thanks!

Is it guaranteed that RTL support is coming in the next version?

@khaydarov
Copy link
Member

@gincher could you re-open your PR, please? It seems to be unavailable

@arfrix
Copy link

arfrix commented Jun 15, 2020

I'll need that too

@ImangazalievM ImangazalievM mentioned this pull request Jul 25, 2020
@talyguryn talyguryn closed this Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants