Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix getRangeAt IndexSizeError #953

Closed
wants to merge 3 commits into from
Closed

fix getRangeAt IndexSizeError #953

wants to merge 3 commits into from

Conversation

breezes1
Copy link

@breezes1
Copy link
Author

#939

neSpecc
neSpecc reviewed Nov 22, 2019
View reviewed changes
src/components/selection.ts Outdated
@@ -176,6 +176,8 @@ export default class SelectionUtils {
return rect;
}

if (sel.rangeCount === 0) { return rect; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the code style guide:

Suggested change
if (sel.rangeCount === 0) { return rect; }
if (sel.rangeCount === 0) {
return rect;
}

@gohabereg
Copy link
Member

Resolved by #968

@gohabereg gohabereg closed this Nov 30, 2019
@breezes1 breezes1 deleted the bugfix/selection-rangecount branch December 20, 2019 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neSpecc neSpecc neSpecc left review comments

@gohabereg gohabereg Awaiting requested review from gohabereg gohabereg is a code owner

@khaydarov khaydarov Awaiting requested review from khaydarov khaydarov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@breezes1 @gohabereg @neSpecc