Merge pull request #1491 from codidact/0valt/1488/vote-summary-fix

Fix server error on user profile vote summary tab if there are orphaned votes

app/controllers/users_controller.rb

@@ -574,18 +574,21 @@ def my_vote_summary
   end
 
   def vote_summary
-    @votes = Vote.where(recv_user: @user) \
-                 .includes(:post).group(:date_of, :post_id, :vote_type)
-    @votes = @votes.select(:post_id, :vote_type) \
-                   .select('count(*) as vote_count') \
-                   .select('date(created_at) as date_of')
+    @votes = Vote.where(recv_user: @user)
+                 .includes(:post)
+                 .group(:date_of, :post_id, :vote_type)
+
+    @votes = @votes.select(:post_id, :vote_type)
+                   .select('count(*) as vote_count')
+                   .select('date(votes.created_at) as date_of')
+
     @votes = @votes.order(date_of: :desc, post_id: :desc).all \
                    .group_by(&:date_of).map do |k, vl|
                      [k, vl.group_by(&:post), vl.sum { |v| v.vote_type * v.vote_count }]
                    end \
                    .paginate(page: params[:page], per_page: 15)
+
     render layout: 'without_sidebar'
-    @votes
   end
 
   def avatar

app/jobs/cleanup_votes_job.rb

@@ -0,0 +1,32 @@
+class CleanupVotesJob < ApplicationJob
+  queue_as :default
+
+  def perform
+    Community.all.each do |c|
+      RequestContext.community = c
+      orphan_votes = Vote.all.reject { |v| v.post.present? }
+
+      puts "[#{c.name}] destroying #{orphan_votes.length} #{'orphan vote'.pluralize(orphan_votes.length)}"
+
+      system_user = User.find(-1)
+
+      orphan_votes.each do |v|
+        result = v.destroy
+
+        if result
+          AuditLog.admin_audit(
+            comment: "Deleted orphaned vote for user ##{v.recv_user_id} " \
+                     "on post ##{v.post_id} " \
+                     "in community ##{c.id} (#{c.name})",
+            event_type: 'vote_delete',
+            related: v,
+            user: system_user
+          )
+        else
+          puts "[#{c.name}] failed to destroy vote \"#{v.id}\""
+          v.errors.each { |e| puts e.full_message }
+        end
+      end
+    end
+  end
+end

app/models/vote.rb

@@ -34,37 +34,45 @@ def reverse_rep_change
   end
 
   def rep_change(direction)
+    return unless post.present?
+
     change = CategoryPostType.rep_changes[[post.category_id, post.post_type_id]][vote_type] || 0
     recv_user.update!(reputation: recv_user.reputation + (direction * change))
   end
 
   def post_not_deleted
-    if post.deleted?
+    if post&.deleted?
       errors.add(:base, 'Votes are locked on deleted posts')
     end
   end
 
   def check_valid
-    throw :abort unless valid?
+    throw :abort unless valid? || post.blank?
   end
 
   def add_counter
+    return unless post.present?
+
     case vote_type
     when 1
       post.update(upvote_count: post.upvote_count + 1)
     when -1
       post.update(downvote_count: post.downvote_count + 1)
     end
+
     post.recalc_score
   end
 
   def remove_counter
+    return unless post.present?
+
     case vote_type
     when 1
       post.update(upvote_count: [post.upvote_count - 1, 0].max)
     when -1
       post.update(downvote_count: [post.downvote_count - 1, 0].max)
     end
+
     post.recalc_score
   end
 end

app/views/users/vote_summary.html.erb

@@ -40,15 +40,21 @@
         </div>
         <div class="item-list--text-value is-primary grid">
             <div class="grid grid--cell is-12">
-                <div class="grid--cell is-flexible">
-                    <%= link_to generic_share_link(post) do %>
-                        <%= post.post_type.is_top_level ? post.title : post.parent.title %>
-                    <% end %>
-                </div>
-                <div class="grid--cell">
-                    <span class="badge is-tag is-muted is-filled"><%= post.post_type.name %></span>
-                    <a href="<%= category_path(post.category) %>" class="badge is-tag is-muted"><%= post.category.name %></a>
-                </div>
+                <% if post.present? %>
+                    <div class="grid--cell is-flexible">
+                            <%= link_to generic_share_link(post) do %>
+                                <%= post.post_type.is_top_level ? post.title : post.parent.title %>
+                            <% end %>
+                    </div>
+                    <div class="grid--cell">
+                        <span class="badge is-tag is-muted is-filled"><%= post.post_type.name %></span>
+                        <a href="<%= category_path(post.category) %>" class="badge is-tag is-muted"><%= post.category.name %></a>
+                    </div>
+                <% else %>
+                    <div class="grid--cell">
+                        <%= I18n.t('votes.summary.post_missing') %>
+                    </div>
+                <% end %>
             </div>
         </div>
     </div>

config/locales/strings/en.votes.yml

@@ -0,0 +1,4 @@
+en:
+  votes:
+    summary:
+      post_missing: 'Post not found'

config/schedule.rb

@@ -18,6 +18,10 @@
   runner 'scripts/cleanup_drafts.rb'
 end
 
+every 1.day, at: '02:25' do
+  runner 'scripts/cleanup_votes.rb'
+end
+
 every 6.hours do
   runner 'scripts/recalc_abilities.rb'
 end

scripts/cleanup_votes.rb

@@ -0,0 +1 @@
+CleanupVotesJob.perform_later