to make it easier to translate #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtOfCode-
requested changes
Jan 23, 2021
ArtOfCode-
approved these changes
Jan 26, 2021
|
Thanks! |
|
Thanks @dyaskur! What should folks know going forward, to avoid regressing? For example, if we add new UI elements that have text, what's the right way to do it? (The question on collab.codidact.org about this might be a good place to document best practices for new code.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no problem with this, I will do more like this.
Sorry if any wrong/bad practice, feel free to give criticism and suggestions