Add post count to Search results page #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added search results post count and adjusted styling to accommodate
Adjusted styling to better conform with project standards.
|
"Posts" looks like a good choice to me -- as you said, it's consistent. And I don't think we return a post more than once no matter how many search results it might contain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a post count to the Search page, based on issue 956.
One thing I was uncertain about is whether the text should be Post(s) or Result(s). I figured that because the search returns only posts at this time, it makes sense to label the count "Posts" - which is consistent the count labelling on other pages.