Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#88: XMPP Ping #119

Merged
merged 10 commits into from
Oct 31, 2020
Merged

#88: XMPP Ping #119

merged 10 commits into from
Oct 31, 2020

Conversation

ForNeVeR
Copy link
Member

@ForNeVeR ForNeVeR commented Oct 1, 2020

This has been done according to the XEP-0199: XMPP Ping.

The original idea (that should work, theoretically) is for bot to ping itself in the room (i.e. to ping its room "avatar", [email protected]/myBotNickname).

Closes #88 (because it finishes the work on that issue).

TODO:

  • wait for publication of a new SharpXMPP version

@ForNeVeR ForNeVeR requested a review from gsomix October 1, 2020 17:21
@ForNeVeR ForNeVeR self-assigned this Oct 1, 2020
@ForNeVeR ForNeVeR marked this pull request as ready for review October 3, 2020 15:07
Copy link
Contributor

@gsomix gsomix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ForNeVeR
Copy link
Member Author

Thanks for review!

@ForNeVeR ForNeVeR merged commit f602d56 into master Oct 31, 2020
@ForNeVeR ForNeVeR deleted the feature/88.ping branch October 31, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Silent connection failure
2 participants