Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telegram HTTP proxy redirector #148

Merged
merged 26 commits into from
Nov 7, 2021
Merged

Conversation

ForNeVeR
Copy link
Member

@ForNeVeR ForNeVeR commented Oct 10, 2021

Part of #147.

TODO:

  • Fix tests
  • Finalize the storage system
  • Run migrations on application start
  • Make sure there are no TODOs remaining in the code
  • Document the infrastructure requirements
    • Make sure any of the new requirements are optional

@ForNeVeR ForNeVeR force-pushed the feature/102.tg-content-proxy branch from c1f5cdc to a65aa70 Compare October 10, 2021 13:27
@ForNeVeR ForNeVeR force-pushed the feature/102.tg-content-proxy branch from 00ae1d5 to 8903eb8 Compare October 30, 2021 16:32
@ForNeVeR ForNeVeR requested a review from gsomix October 31, 2021 12:49
@ForNeVeR ForNeVeR marked this pull request as ready for review October 31, 2021 12:49
@ForNeVeR ForNeVeR force-pushed the feature/102.tg-content-proxy branch from 795fc9c to 463f3d1 Compare October 31, 2021 13:22
@ForNeVeR ForNeVeR force-pushed the feature/102.tg-content-proxy branch from 2b4127f to 86c86b6 Compare October 31, 2021 13:47
Copy link
Contributor

@gsomix gsomix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but some comments are needed. It might be good idea to add it into code.

Comment on lines +11 to +14
// We cannot use Option.ofObj here since not every entity type can be marked with AllowNullLiteral.
match box item with
| null -> return None
| _ -> return Some item
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// We cannot use Option.ofObj here since not every entity type can be marked with AllowNullLiteral.
match box item with
| null -> return None
| _ -> return Some item
return Option.ofObj (box item)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha-ha, sorry but nope:

Error: /home/runner/work/emulsion/emulsion/Emulsion.Database/QueryableEx.fs(11,12): error FS0001: A type parameter is missing a constraint 'when 'a : null' [/home/runner/work/emulsion/emulsion/Emulsion.Database/Emulsion.Database.fsproj]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wtf?!

Emulsion/Telegram/Funogram.fs Show resolved Hide resolved
Emulsion/Telegram/LinkGenerator.fs Show resolved Hide resolved
@ForNeVeR
Copy link
Member Author

ForNeVeR commented Nov 7, 2021

Thanks a lot for review!

@ForNeVeR ForNeVeR force-pushed the feature/102.tg-content-proxy branch from 5c98d8a to 628550b Compare November 7, 2021 15:23
@ForNeVeR ForNeVeR merged commit 628550b into master Nov 7, 2021
@ForNeVeR ForNeVeR deleted the feature/102.tg-content-proxy branch November 7, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants