-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telegram HTTP proxy redirector #148
Conversation
Microsoft.Extensions.Configuration.Abstractions package is referenced by the platform anyway.
c1f5cdc
to
a65aa70
Compare
00ae1d5
to
8903eb8
Compare
795fc9c
to
463f3d1
Compare
2b4127f
to
86c86b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but some comments are needed. It might be good idea to add it into code.
// We cannot use Option.ofObj here since not every entity type can be marked with AllowNullLiteral. | ||
match box item with | ||
| null -> return None | ||
| _ -> return Some item |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// We cannot use Option.ofObj here since not every entity type can be marked with AllowNullLiteral. | |
match box item with | |
| null -> return None | |
| _ -> return Some item | |
return Option.ofObj (box item) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha-ha, sorry but nope:
Error: /home/runner/work/emulsion/emulsion/Emulsion.Database/QueryableEx.fs(11,12): error FS0001: A type parameter is missing a constraint 'when 'a : null' [/home/runner/work/emulsion/emulsion/Emulsion.Database/Emulsion.Database.fsproj]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wtf?!
Thanks a lot for review! |
5c98d8a
to
628550b
Compare
Part of #147.
TODO: