refactor: split Cart component into functional (Cart) and view parts (CartView) #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for home-goods-store ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tetianaman
force-pushed
the
tetianaman/refactor-cart-components
branch
from
f38af6b to
1427634
Compare
tetianaman
changed the title
yurii-ve
reviewed
Oct 14, 2024
| export interface CartViewProps { | ||
| cart?: Cart; | ||
| cartTotals?: CartTotals; | ||
| close: () => void; |
yurii-ve
approved these changes
Oct 14, 2024
Letushev
reviewed
Oct 14, 2024
| fullPrice: string; | ||
| } | ||
|
|
||
| export const Price = ({ fullPrice, discountedPrice }: PriceProps) => { |
There was a problem hiding this comment.
We already had this component. ProductPrice
There was a problem hiding this comment.
will remove, thnx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The work follows e-commerce-remix template refactorings (PR, PR).
CartViewcomponentCartcomponent to handle all the logic and renderCartViewCartItemuseCarthook copiedPriceis copied from remix template, no changesuseCartapi-hook renamed touseCartDataNo updating states (no loaders) for Cart items and Cart summary in this PR.