-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate classmap #60
Conversation
That never should've happened!
@BrianHenryIE Isn't this creating a duplicate file from what is already stored in the default classmap autoloader that Composer generates? I recall that the default classmap autoloader also contains the prefixed classes. |
I'll fix this soon. I don't use composer in my actual plugins, just in dev. Unfortunately, I don't have anything public on GitHub that's actually using the classmap but you can see the idea at this project – Mozart copies and prefixes packages into I mentioned my lack of understanding in one of the issues, maybe you could add a couple of words/links in the README to explain things to novices. I think that could be valuable to many WordPress developers! |
@BrianHenryIE You know how much I appreciate all the good work you do for this project, right? For now, I'd like you to pause this particular functionality for a while. @markjaquith and I have been turning this whole idea upside down in #66 now. Even though we're not quite close to white smoke, I doubt that this current approach is going to survive eventually and I'd hate for you to spend much more time on this than you already have. |
Sure. Since I'm already using it (with composer-patches) there might be a few commits to keep it working for me. But.. I'm still in the dark as to how you are including "classmap" files in your projects. You run |
I drastically simplified this. It uses Composer itself now to generate the classmap. Doesn't need any config in composer.json. Adds |
This is using |
It was printing the entire files' contents in the console.
This PR adds creation of a classmap file from the
PSR-0"classmap_directory" files managed by Mozart.Defaults to none.
Configured in
composer.json
withThen used in the plugin with: