call .read() only once when dataset do not have nodata #355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a dataset that has a mask or and alpha band (by default every data that don't have Nodata set will have an alpha/mask band within the WarpedVRT instance) we were doing two
read()
, one for the data, another one for the mask. This PR changes the behavior and performs only one read() and then split the data and the mask to two arrays.☝️ this is a profiling results that show that the
method 'read' of 'rasterio._warp.WarpedVRTReaderBase' objects
was called twice and only once in the new version.