-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Ansible Core 2.16.0 Publish Issues #64
base: main
Are you sure you want to change the base?
Conversation
kavinagrawalcohesity
commented
Jan 29, 2025
•
edited
Loading
edited
- Ansible core 2.16.0 lint issue fixes
- Documentation Change
- Ansible module docs changes
plugins/modules/cohesity_policy.py
Outdated
@@ -115,7 +115,7 @@ | |||
state: present | |||
name: 'Ansible' | |||
incremental_backup_schedule: | |||
periodicity: Daily | |||
periodicity: Daily |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The periodicity should be nested here. It looks to be part of incremental_backup_schedule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -204,14 +204,13 @@ | |||
endpoint: "myvcenter.cohesity.demo" | |||
files: | |||
- "/home/cohesity/sample" | |||
wait_for_job: True | |||
wait_for_job: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing 'yes' to . Is this verified?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ansible interprets the following values as True:
true
yes
on
1
And following values as False:
false
no
off
0
@@ -1,4 +1,4 @@ | |||
cohesity-management-sdk==1.10.1 | |||
pywinrm | |||
requests==2.31.0 | |||
ansible==9.2.0 | |||
ansible-core==2.16.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is ansible==9.2.0 not a requirement anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have replaced ansible community package with the ansible core package as dependency