Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Ansible Core 2.16.0 Publish Issues #64

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

kavinagrawalcohesity
Copy link
Contributor

@kavinagrawalcohesity kavinagrawalcohesity commented Jan 29, 2025

  1. Ansible core 2.16.0 lint issue fixes
  2. Documentation Change
  3. Ansible module docs changes

@@ -115,7 +115,7 @@
state: present
name: 'Ansible'
incremental_backup_schedule:
periodicity: Daily
periodicity: Daily

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The periodicity should be nested here. It looks to be part of incremental_backup_schedule.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -204,14 +204,13 @@
endpoint: "myvcenter.cohesity.demo"
files:
- "/home/cohesity/sample"
wait_for_job: True
wait_for_job: true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing 'yes' to . Is this verified?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ansible interprets the following values as True:
true
yes
on
1

And following values as False:
false
no
off
0

@@ -1,4 +1,4 @@
cohesity-management-sdk==1.10.1
pywinrm
requests==2.31.0
ansible==9.2.0
ansible-core==2.16.3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ansible==9.2.0 not a requirement anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have replaced ansible community package with the ansible core package as dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants