Update linux-ci and windows-ci for nodejs 20 upgrades and PR artifact #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhmgoossens
added a commit
that referenced
this pull request
Mar 14, 2024
…#220) * Update linux-ci and windows-ci for nodejs 20 upgrades * Update linux-ci and windows-ci for PR artifact name * Update windows-ci for remaining nodejs 20 issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the affected github actions to version that use node.js 20.
Also updated the linux-ci and windows-ci PR asset names used by the upload-artifact action: any special characters like '/' in the origin branch name of a PR cause errors. Therefore, removed the head_ref (branch name) from the asset name.