Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[meta] update package.json, actions #19

Merged
merged 1 commit into from
Apr 21, 2022
Merged

[meta] update package.json, actions #19

merged 1 commit into from
Apr 21, 2022

Conversation

ljharb
Copy link
Contributor

@ljharb ljharb commented Apr 21, 2022

No description provided.

@ljharb ljharb requested review from gksander and lachiet April 21, 2022 17:35
@ljharb
Copy link
Contributor Author

ljharb commented Apr 21, 2022

node 18 is broken due to nodejs/node#42638 (comment), so i'm going to make it an allowed failure for now.

@ljharb ljharb force-pushed the actions branch 2 times, most recently from 5c97c3f to 19e529f Compare April 21, 2022 18:00
@ljharb
Copy link
Contributor Author

ljharb commented Apr 21, 2022

Unfortunately, continue-on-error shows up this way - as failures on "not the required" checks

gksander
gksander previously approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@gksander gksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@ljharb
Copy link
Contributor Author

ljharb commented Apr 21, 2022

update one more time to add a "everything's done" job after the matrix is finished

@gksander gksander merged commit 49426a3 into main Apr 21, 2022
@gksander gksander deleted the actions branch April 21, 2022 18:27
ghost
ghost reviewed Sep 22, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COINBASE PAY

Jphaphon1
Jphaphon1 reviewed Jun 18, 2023
View reviewed changes
Copy link

@Jphaphon1 Jphaphon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jphaphon1 Jphaphon1 Jphaphon1 left review comments

@gksander gksander gksander approved these changes

@lachiet lachiet Awaiting requested review from lachiet

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ljharb @gksander @Jphaphon1