Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Inactive Account Reconciliation #13

Merged
merged 2 commits into from
Apr 30, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Apr 30, 2020

Motivation

Inactive account reconciliation is very simple. It doesn't wait a minimum number of blocks between checks and doesn't prevent multiple goroutines from checking the balance of an account at the same time.

Solution

This PR adds support for the features described in the motivation. It also extends the retry elapsed time from 1 Minute to 5 minutes.

Future PR

  • Unify stateful/stateless reconciler
  • Add inactive reconciliation to check:quick

@patrick-ogrady patrick-ogrady merged commit 0f29df2 into master Apr 30, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/better-inactive-reconciliation branch April 30, 2020 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants