Bootstrap Reconciler with Previously Seen Accounts #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When re-running the
check
command with a provided--data-dir
, the previously seen accounts in the reconciler are discarded. This greatly impacts the efficacy of the inactive reconciler across restarts (as it randomly checks all accounts seen).Solution
Bootstrap the reconciler with all accounts saved to storage. This allows inactive reconciliation to continue on accounts only seen in previous runs of
rosetta-cli check
.Related PRs
Other Improvements
OperationGroups
for each transaction in theview:block
command.version
command.Warning
This PR introduces changes to how data is stored in
rosetta-cli
. If you are using a persistent store (populating the--data-dir
when runningrosetta-cli check
), you must delete this store and create a new one. We don't expect any further changes to how data is stored in the near future.