Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap Reconciler with Previously Seen Accounts #19

Merged
merged 10 commits into from
May 13, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented May 13, 2020

Motivation

When re-running the check command with a provided --data-dir, the previously seen accounts in the reconciler are discarded. This greatly impacts the efficacy of the inactive reconciler across restarts (as it randomly checks all accounts seen).

Solution

Bootstrap the reconciler with all accounts saved to storage. This allows inactive reconciliation to continue on accounts only seen in previous runs of rosetta-cli check.

Related PRs

Other Improvements

  • Print out OperationGroups for each transaction in the view:block command.
  • Add new version command.

Warning

This PR introduces changes to how data is stored in rosetta-cli. If you are using a persistent store (populating the --data-dir when running rosetta-cli check), you must delete this store and create a new one. We don't expect any further changes to how data is stored in the near future.

@coveralls
Copy link

coveralls commented May 13, 2020

Pull Request Test Coverage Report for Build 985

  • 37 of 45 (82.22%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 75.104%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/storage/badger_storage.go 15 19 78.95%
internal/storage/block_storage.go 22 26 84.62%
Totals Coverage Status
Change from base Build 926: 0.3%
Covered Lines: 362
Relevant Lines: 482

💛 - Coveralls

Copy link

@brockmiller brockmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Love the coverage report as well.

@patrick-ogrady patrick-ogrady merged commit cc2e0c4 into master May 13, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/persist-inactive branch May 13, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants