Add separate config to disable balance pruning #354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeekArthur
requested changes
Sep 14, 2022
pkg/processor/reconciler_helper.go
Outdated
| @@ -153,7 +153,7 @@ func (h *ReconcilerHelper) PruneBalances( | |||
| currency *types.Currency, | |||
| index int64, | |||
| ) error { | |||
| if h.config.Data.PruningDisabled { | |||
| if h.config.Data.PruningDisabled || h.config.Data.PruningBalanceDisabled { | |||
There was a problem hiding this comment.
We can fully decouple pruning, so only h.config.Data.PruningBalanceDisabled is needed here
There was a problem hiding this comment.
I fixed it that way to respect the intent of the original author.
Okay, I will fix the code so that only PruningBalanceDisabled is needed. I also think that is better.
|
@sink772 Please also fix the CI test for introducing new config |
GeekArthur
approved these changes
Sep 19, 2022
|
@sink772 Approved, the commits need to be signed for merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We are experiencing a similar performance issue described in #316, when we are running
check:datacommand.We found that
PruneBalancesoperation is the root culprit of the performance issue.As you know, by default, the
PruneBalancesis called whenever a balance change happened for an account in a block.BTW, in some blockchains (like ICON), there is an account that is always included in every block (eg,
fee_treasury), which makes only one reconcile goroutine is effectively active and the other goroutines that callreconcileActiveAccountsmethod would block onrosetta-sdk-go/storage/database.(*BadgerDatabase).WriteTransaction.Solution
There is an existing config for disabling pruning,
PruningDisabled. But this config also applies to the state storage pruning.We want to introduce a separate config only for balance pruning operation, named
PruningBalanceDisabled.Open questions
None