Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print Periodic Stats #58

Merged
merged 4 commits into from
Jul 16, 2020
Merged

Print Periodic Stats #58

merged 4 commits into from
Jul 16, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Jul 15, 2020

Fixes #27.
Fixed #35.

Changes

We now print out summary messages every 10 seconds instead of streaming a long list of logs.

Before:
image

After:
image

Additionally, we also print out a warning if a check succeeded but no reconciliations were performed.
image

@coveralls
Copy link

coveralls commented Jul 15, 2020

Pull Request Test Coverage Report for Build 1550

  • 32 of 63 (50.79%) changed or added relevant lines in 3 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 60.132%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/processor/reconciler_handler.go 0 6 0.0%
internal/storage/counter_storage.go 32 40 80.0%
internal/processor/syncer_handler.go 0 17 0.0%
Files with Coverage Reduction New Missed Lines %
internal/processor/syncer_handler.go 4 0%
Totals Coverage Status
Change from base Build 1505: -0.5%
Covered Lines: 454
Relevant Lines: 755

💛 - Coveralls

@patrick-ogrady patrick-ogrady force-pushed the patrick/periodic-stats branch from be97442 to 1151e4a Compare July 15, 2020 23:59
@patrick-ogrady patrick-ogrady force-pushed the patrick/periodic-stats branch from 1151e4a to de0dd53 Compare July 16, 2020 00:01
@patrick-ogrady patrick-ogrady changed the title [WIP] Print Periodic Stats Print Periodic Stats Jul 16, 2020
@patrick-ogrady patrick-ogrady requested review from niallo, juliankoh, a team and yfl92 July 16, 2020 00:12
@patrick-ogrady patrick-ogrady merged commit f915cdb into master Jul 16, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/periodic-stats branch July 16, 2020 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Print Temporary Directory Print Periodic Stats
3 participants