ProtoJSON safely encode JSON to ASCII-8BIT (String#b) (#264)

coinbase · Oct 11, 2023 · 0540942 · 0540942
1 parent d75dfee
commit 0540942
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/temporal/connection/converter/payload/proto_json.rb b/lib/temporal/connection/converter/payload/proto_json.rb
@@ -25,7 +25,7 @@ def to_payload(data)
                 'encoding' => ENCODING,
                 'messageType' => data.class.descriptor.name,
               },
-              data: data.to_json,
+              data: data.to_json.b,
             )
           end
         end

diff --git a/spec/unit/lib/temporal/connection/converter/payload/proto_json_spec.rb b/spec/unit/lib/temporal/connection/converter/payload/proto_json_spec.rb
@@ -15,6 +15,13 @@
 
       expect(subject.from_payload(subject.to_payload(input))).to eq(input)
     end
+
+    it 'encodes special characters' do
+      input = Temporalio::Api::Common::V1::Payload.new(
+        metadata: { 'it’ll work!' => 'bytebytebyte' },
+      )
+      expect(subject.from_payload(subject.to_payload(input))).to eq(input)
+    end
   end
 
   it 'skips if not proto message' do