Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify the Getting Started section so that it works #131

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Modify the Getting Started section so that it works #131

merged 1 commit into from
Jan 21, 2022

Conversation

chuckremes2
Copy link
Contributor

  • removed metacharacters from the shell commands so they can be
    copy/pasted directly

  • added require 'temporal-ruby' for each example that needs it

  • made it clear that the worker and workflow both need access to
    the same configuration step, so it should be its own file

  • made it clear the worker and workflow files need to be executed
    in their own terminals/shells

@chuckremes2
Modify the Getting Started section so that it works
6adb4e4 
- removed metacharacters from the shell commands so they can be
copy/pasted directly

- added require 'temporal-ruby' for each example that needs it

- made it clear that the worker and workflow both need access to
the same configuration step, so it should be its own file

- made it clear the worker and workflow files need to be executed
in their own terminals/shells
@DeRauk DeRauk merged commit f4c57b5 into coinbase:master Jan 21, 2022
@DeRauk DeRauk added the sync pending Needs to be ported to cadence-ruby label Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeRauk DeRauk DeRauk approved these changes

Assignees
No one assigned
Labels
sync pending Needs to be ported to cadence-ruby
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chuckremes2 @DeRauk