Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow tag to metrics emitted from the activity task processor #133

Conversation

christopherb-stripe
Copy link
Contributor

We've found it helpful to tag activity metrics with the workflow name that called them so that we can build a dashboard that includes all related information for a workflow. The tag is named the same as other workflow tags in the library e.g. in the workflow task processor.

This PR also sneaks a fix for a logging typo in too.

@DeRauk
Copy link
Contributor

DeRauk commented Feb 4, 2022

Thanks @christopherb-stripe!

@DeRauk DeRauk merged commit 101ec13 into coinbase:master Feb 4, 2022
@DeRauk DeRauk added the sync pending Needs to be ported to cadence-ruby label Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sync pending Needs to be ported to cadence-ruby
Development

Successfully merging this pull request may close these issues.

None yet

2 participants